[Splashy-devel] 4a/6 Make simple interface for splashy_video.h

[Tim Dijkstra]

On Mon, 14 Aug 2006 10:01:19 -0400
Pat Suwalski <pats at xandros.com> wrote:

> Tim Dijkstra wrote:
> > [4/6 was to big for the list]
> > Remove "splashy_video_t * video" from the functions argument list,
> > make an instance of splashy_video_t local to splashy_video.c
> > instead. That way the rest of splashy doesn't have to know about
> > splashy_video_t at all. 
> 
> Isn't this the sort of change that is opposite of how most projects 
> organize their code? I've always considered it good style to pass a 
> pointer to an "object" rather than have it globally-accessible...
> 
> The other patches look good.

Well, we will always have only one splash screen, so there is no need
to have a pointer to a specific one. It seems a bit silly to always
pass around an object if it's always the same object. Global objects
are of course frowned upon, but it think this is an instance where it
is useful.
If we still decide to stay with a pointer variable, I definitely want
to change the struct, now it exposes a lot of structures to the
user of the library that really should be private.

grts Tim
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/splashy-devel/attachments/20060815/2a5b7475/signature.pgp