[Splashy-devel] Bug#455685: Splashy makes GDM initscript fail (and hence, leaves system on VT1)

[Luis Mondesi]

On Dec 22, 2007 12:11 PM, Steve Fosdick <dbugs at pelvoux.nildram.co.uk> wrote:

> I have had the same issue with gdm not starting when splashy is installed.
>
> I have checked line 178 of /etc/lsb-base-logging.sh but in the version
> installed on my system this line is a comment so I can not see how, in my
> case, that line could be causing the error.
>
> The failure mechanism seems to be that /etc/init.d/gdm has performed 'set
> -e' so that any command that fails, even if there is no error message or the
> message is surpressed by re-directing to /dev/null, will cause
> /etc/init.d/gdm to stop executing at that point.  With splashy installed and
> its corresponding /etc/lsb-base-logging.sh the log_daemon_msg subroutine
> is failing and thus aborting /etc/init.d/gdm.
>
> I haven't had a chance to work through all the commands splashy is running
> but perhaps there are some assumptions there that don't hold true.  For
> example, in my case, splashy was installed because it was recommended by
> uswsusp and is therefore used for the suspend/resume progress screen but I
> have not yet got around to setting it up for normal startup/shutdown.
>
> Anyway, for now, I have been able to work around this patching /etc/lsb-
> base-logging.sh as follows:
>
> diff -u lsb-base-logging-orig.sh lsb-base-logging.sh
> --- lsb-base-logging-orig.sh    2007-12-22 17:09:34.000000000 +0000
> +++ lsb-base-logging.sh 2007-12-22 17:03:52.000000000 +0000
> @@ -118,7 +118,7 @@
>
>     # Stop splashy on *dm
>     case $2 in
> -       ?dm) stop_splashy;;
> +       ?dm) stop_splashy || return 0 ;;
>     esac
>  }
>
> So even if attempting to stop splashy fails gdm still starts.
>

Hello Steve,

Thanks for suggesting this fix. We included this in our  latest script [1].
This will be released as Splashy 0.3.9.

Please note that Splashy 0.3.8 included code that prevented this from
happening by doing the right thing when stop_splashy is called:
- only run keymap.sh if splashy prevented it from starting. do the same for
console-screen.sh
- only umount Splashy's steps dir if it's mounted

However, it doesn't hurt to have "|| return 0" in the log_daemon_msg() call
as well.

Splashy 0.3.8 will be added to the debian archives soon. It has not been
added yet because we are all in "holidays" mode and the whole
release/bug-fix cycle has been reduced in speed ;-)

If you are reading this bug and you are having problems with gdm or any
other script, please just grab a copy of lsb-base-logging.sh and replace
your /etc/lsb-base-logging.sh copy with this [1].

Notes:
1.
http://git.debian.org/?p=splashy/splashy.git;a=blob_plain;f=scripts/lsb-base-logging.sh;hb=HEAD

-- 
----)(-----
Luis Mondesi
Maestro Debiano

----- START ENCRYPTED BLOCK (Triple-ROT13) ------
Gur Hohagh [Yvahk] qvfgevohgvba oevatf gur fcvevg bs Hohagh gb gur fbsgjner
jbeyq.
----- END ENCRYPTED BLOCK (Triple-ROT13) ------
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.alioth.debian.org/pipermail/splashy-devel/attachments/20071223/563f255a/attachment.htm