[Splashy-devel] Bug#455685: splashy: display manager script doesn't start when no splash kernel option

[Luca Capello]

reopen 455685 Luca Capello <luca at pca.it>
found 455685 0.3.8-1
severity 455685 important
tags 455685 + patch
thanks

Hello,

cc:ing all the people involved in this bug, so in case they can test if
the bug is a general one (i.e. not specific to xdm) and in this case
test my fix.

With the latest splashy update, xdm doesn't work any more on my sid.
ATM I don't use splashy, but since it's still installed,
/etc/lsb-base-logging.sh replaces /usr/lib/lsb-init-functions.  And this
is the cause I discovered from `invoke-rc.d xdm start` after having set
the -x option for /etc/init.d/xdm gives:
=====
+ '[' -z '' ']'
+ HEED_DEFAULT_DISPLAY_MANAGER=true
+ DEFAULT_DISPLAY_MANAGER_FILE=/etc/X11/default-display-manager
+ PATH=/bin:/usr/bin:/sbin:/usr/sbin
+ DAEMON=/usr/bin/xdm
+ PIDFILE=/var/run/xdm.pid
+ test -x /usr/bin/xdm
+ . /lib/lsb/init-functions
++ FANCYTTY=
++ '[' -e /etc/lsb-base-logging.sh ']'
++ . /etc/lsb-base-logging.sh
++ basename /usr/bin/xdm
+ SSD_START_ARGS='--pidfile /var/run/xdm.pid --name xdm --startas /usr/bin/xdm'
++ basename /usr/bin/xdm
+ SSD_STOP_ARGS='--pidfile /var/run/xdm.pid --name xdm --retry TERM/5/TERM/5'
++ basename /usr/bin/xdm
+ SSD_RELOAD_ARGS='--pidfile /var/run/xdm.pid --name xdm --signal 1'
+ case "$1" in
+ '[' true = true ']'
+ '[' -e /etc/X11/default-display-manager ']'
++ cat /etc/X11/default-display-manager
+ '[' /usr/bin/xdm '!=' /usr/bin/xdm ']'
+ log_daemon_msg 'Starting X display manager' xdm
+ '[' -z 'Starting X display manager' ']'
+ '[' -z xdm ']'
+ echo -n 'Starting X display manager: xdm'
Starting X display manager: xdm+ pidof splashy
+ case $2 in
+ stop_splashy
+ STEPS_DIR=/lib/init/rw/splashy
+ SPL_UPD=/sbin/splashy_update
+ '[' -r /etc/default/splashy ']'
+ . /etc/default/splashy
++ CHVT_TTY=
++ ENABLE_INITRAMFS=1
++ DEBUG=0
+ pidof splashy
+ '[' '!' -d /lib/init/rw/splashy ']'
+ '[' x0 '!=' x0 ']'
+ sleep 0.2
++ pidof splashy
+ '[' -z '' ']'
+ '[' -x /etc/init.d/keymap.sh -a -f /dev/shm/splashy-stopped-keymap ']'
+ '[' -x /etc/init.d/console-screen.sh -a -f /dev/shm/splashy-stopped-console-screen ']'
+ '[' x0 = x0 ']'
+ mount
+ grep /lib/init/rw/splashy
invoke-rc.d: initscript xdm, action "start" failed.
=====

I already proposed one correct solution on bug #451846 [1]: the modified
log_daemon_msg() should not execute splashy code when splashy is not
running.  This is what happens in log_end_msg() and applying the patch
that I proposed on that bug solves the problem:

--8<---------------cut here---------------start------------->8---
--- lsb-base-logging.sh.ORG	2007-12-26 21:27:09.000000000 +0100
+++ lsb-base-logging.sh	2007-12-28 19:10:03.000000000 +0100
@@ -113,6 +113,9 @@
     ##############################################################
     # Splashy code 
    
+    # We do nothing if splashy is not running
+    pidof splashy > /dev/null || return 0
+
     # send log to splashy. it will show if F2 is pressed
     pidof splashy > /dev/null && splashy_update "scroll $1: $2"
 
--8<---------------cut here---------------end--------------->8---

Please consider for inclusion, TIA.

Thx, bye,
Gismo / Luca

Footnotes: 
[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?archive=yes&bug=451846#47

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.24-rc5-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages splashy depends on:
ii  initramfs-tools         0.91d            tools for generating an initramfs
ii  libc6                   2.7-5            GNU C Library: Shared libraries
ii  libdirectfb-1.0-0       1.0.1-5          direct frame buffer graphics - sha
ii  libgcc1                 1:4.2.2-4        GCC support library
ii  libglib2.0-0            2.14.4-2         The GLib library of C routines
ii  libmagic1               4.21-4           File type determination library us
ii  libsplashy1             0.3.8-1          Library to draw splash screen on b
ii  lsb-base                3.1-24           Linux Standard Base 3.1 init scrip
ii  zlib1g                  1:1.2.3.3.dfsg-8 compression library - runtime

splashy recommends no packages.

-- no debconf information
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/splashy-devel/attachments/20071228/311daf6d/attachment.pgp