Bug#410861: [Splashy-devel] Bug#410861: initscript does not detect "splash" boot parameter if splash is the last boot option

[Tim Dijkstra]

On Wed, 14 Feb 2007 18:35:07 -0200
Otavio Salvador <otavio at debian.org> wrote:

> Tim Dijkstra <tim at famdijkstra.org> writes:
> 
> > On Tue, 13 Feb 2007 23:56:21 +0100
> > Michael Biebl <biebl at debian.org> wrote:
> >
> >> Package: splashy
> >> Version: 0.3.1
> >> Severity: normal
> >> 
> >> /etc/init.d/splashy contains:
> >> 
> >> grep -q -e '[[:space:]]splash\([[:space:]]+\|$\)' /proc/cmdline &&
> >> ENABLE=1
> >> grep -q -e '[[:space:]]nosplash\([[:space:]]+\|$\)' /proc/cmdline &&
> >> ENABLE=0
> >> 
> >> If splash is the last boot parameter with no white space following, this
> >> expression does not match, i.e. splash support is disabled although my
> >> grub command line looks like "... vga=791 splash".
> >
> > Have you tested that? Because the regex reads ends on 'space or end' (
> > the '$' means end.) so it does match your case. In other words
> > something else must be wrong.
> 
> The problem was when you _had_ a space after the word. I fixed it on
> svn already. It worked fine on my test case.

I don't see the space. I clearly says |$. But never mind. The change
you did doesn't do any harm.

grts Tim
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/splashy-devel/attachments/20070214/77b1fb8f/signature.pgp