[Splashy-devel] Bug#455685: Splashy makes GDM initscript fail (and hence, leaves system on VT1)

[Vasilis Vasaitis]

reassign 457843 splashy
forcemerge 455685 457843
thanks

  Hi,

  I've been affected by bug #457843 for a while ("gdm init script dies
in log_daemon_msg"), and I decided to investigate. I quickly
identified the file /etc/lsb-base-logging.sh as the culprit, which
belongs to splashy. A bit of playing around with sh -x and I came up
with the following fix (I've tried it and it works):

----------------------------------------
--- lsb-base-logging.sh.orig	2007-12-26 20:27:09.000000000 +0000
+++ lsb-base-logging.sh	2008-01-24 16:59:26.000000000 +0000
@@ -193,7 +193,7 @@
     # when not in debug mode, umount our tmpfs
     if [ "x$DEBUG" = "x0" ]; then
         mount | grep $STEPS_DIR > /dev/null \
-            && umount $STEPS_DIR 2> /dev/null
+            && umount $STEPS_DIR 2> /dev/null || true
     fi
 }

----------------------------------------

  Then I came to the BTS to see if this has already been reported, and
found this bug, #455685. It also appears that apparently I'm not the
first one to come up with this fix, as Luis Mondesi has already
provided a similar patch, which is in fact applied to the current git
version of the file [0]. However, the fix is not included in version
0.3.8-1, and this is probably why people are still reporting problems
with it. Please fix.

Thanks,
Vasilis


[0] http://git.debian.org/?p=splashy/splashy.git;a=blob_plain;f=scripts/lsb-base-logging.sh;hb=HEAD

-- 
Vasilis Vasaitis
"A man is well or woe as he thinks himself so."