[Splashy-devel] Bug#486139: splashy: prevents upgrade from firebird2.0-classic because of not allowing empty $2 in log_daemon_msg

[Alban Browaeys]

Package: splashy
Version: 0.3.10-1
Severity: important
Tags: patch

log_daemon_message can have a second argument that is empty. This breaks
with splashy :
Paramètrage de firebird2.0-classic (2.0.4.13130-1.ds1-3) ...
  * Preparing /var/run/firebird/2.0...
/etc/lsb-base-logging.sh: line 271: $2: unbound variable
invoke-rc.d: initscript firebird2.0-classic, action "start" failed

The attach patch fixes it by checking for the emptyness of $2 before
calling case $2 to check if $2 equals *dm.

I hope the patch is posix compliant though I do not remind if "!" in [  ] is ...

Best regards,
Alban

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.25-rc7-00025-gacaef06-dirty (SMP w/1 CPU core)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages splashy depends on:
ii  initramfs-tools        0.92b             tools for generating an initramfs
ii  libc6                  2.7-12            GNU C Library: Shared libraries
ii  libdirectfb-1.0-0      1.0.1-9           direct frame buffer graphics - sha
ii  libgcc1                1:4.3.1-2         GCC support library
ii  libglib2.0-0           2.16.3-2          The GLib library of C routines
ii  libmagic1              4.24-2            File type determination library us
ii  libsplashy1            0.3.10-1          Library to draw splash screen on b
ii  lsb-base               3.2-12            Linux Standard Base 3.2 init scrip
ii  zlib1g                 1:1.2.3.3.dfsg-12 compression library - runtime

splashy recommends no packages.

-- no debconf information
-------------- next part --------------
--- lsb-base-logging.sh.orig	2008-06-13 14:19:25.000000000 +0200
+++ lsb-base-logging.sh	2008-06-13 14:19:34.000000000 +0200
@@ -268,9 +268,11 @@
         return 0
     fi
 
-    case $2 in 
-	?dm) stop_splashy || true ;;
-    esac
+    if [ ! -z "${2:-}" ]; then
+        case $2 in 
+            ?dm) stop_splashy || true ;;
+        esac
+    fi
 }
 
 log_progress_msg () {