[Splashy-devel] Bug#501997: Bug#501997: splashy: FTBFS when DEB_BUILD_OPTIONS is set to noopt, nostrip

[Adam D. Barratt]

Tim Dijkstra wrote, 2008-10-15 12:38 +0200:
> Bradley Smith schreef:
>> tags 501997 +patch
>>
>> I've tested this and it does indeed fix the problem.
>>
>> I have attached a patch with the actual changes needed.
>>
>> Let me know if you would like an NMU.
>
> I would first want to know why we need that header. Why does it only
> show up if you try to build with these special build options?

If you're building with optimisations enabled, as a Debian package will by 
default, then libintl.h will pull in locale.h for you:

[...]
/* Optimized version of the function above.  */
#if defined __OPTIMIZE__ && !defined __cplusplus
[...]
/* We need LC_MESSAGES for `dgettext'.  */
# include <locale.h>
[...]

DEB_BUILD_OPTIONS=noopt calls gcc with -O0, thereby not defining 
__OPTIMIZE__ and not implicitly pulling in locale.h.

Regards,

Adam