[Teammetrics-discuss] Code Review

Sukhbir Singh sukhbir.in at gmail.com
Wed May 30 17:51:12 UTC 2012

Hi Vipin,

> I have started a new branch called 'web-devel'. All my intermediate
> code will be pushed to this and once we are satisfied with it, will
> move to the main 'web' branch with some documentation, better
> identifiers names :) code optimization and possible unit tests. The
> code in 'web-devel' branch is not clean and is written in a
> get-things-done form.


> I have written a SQL query that fetches data from the database. It
> currently works with one single table but can easily modified it to
> work with other tables as well. The code is on a file called data.sql.
> This is an early version and probably the query can be optimized.

Nitpick: line 21: web/test.py

Consider using a pair of matching triple quotes: ''' or """ to format
a string that spans across multiple lines instead of using \. As an
example, see line 372, liststat.py.

And rest we will wait so that you can set this up on blends.d.n :)


More information about the Teammetrics-discuss mailing list