[ubuntu-dev] Bug#915298: [NMU] Re: Bug#915298: gdebi FTBFS with pyflakes 2.0.0-1

[Axel Beckert]

Control: tag -1 + patch

Hi,

Andrey Rahmatullin wrote:
> ./gdebi-kde:92: local variable 'e' is assigned to but never used
> ./gdebi-gtk:80: local variable 'e' is assigned to but never used
> ./GDebi/KDEAptDialogs.py:147: local variable 'e' is assigned to but never used
> ./GDebi/GDebiKDE.py:363: local variable 'msg' is assigned to but never used
> ./GDebi/GDebiGtk.py:69: local variable 'e' is assigned to but never used
> gdebi-gtk:80: local variable 'e' is assigned to but never used
> gdebi-kde:92: local variable 'e' is assigned to but never used
> 
> I don't think aborting on non-empty pyflakes output, just like compiling
> with -Werror, should be a part of a Debian package build.

I agree, especially in this case of a rather pedantic warning.

I've prepared an NMU which fixes this issue by moving the according
test to a new subdirectory called release_tests (as that is what the
test is) so that it is still available, but not run at build time.

I intent to do an NMU later today.

Here's the debdiff (native package, hence no quilt patches):

diff -Nru gdebi-0.9.5.7+nmu2/debian/changelog gdebi-0.9.5.7+nmu3/debian/changelog
--- gdebi-0.9.5.7+nmu2/debian/changelog	2017-12-31 17:00:13.000000000 +0100
+++ gdebi-0.9.5.7+nmu3/debian/changelog	2019-03-11 16:17:10.000000000 +0100
@@ -1,3 +1,12 @@
+gdebi (0.9.5.7+nmu3) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Move tests/test_pyflakes.py to new directory release_tests which is no
+    more run at build time. (Closes: #915298)
+    + Drop build-dependencies on pyflakes and pyflakes3.
+
+ -- Axel Beckert <abe at debian.org>  Mon, 11 Mar 2019 16:17:10 +0100
+
 gdebi (0.9.5.7+nmu2) unstable; urgency=medium
 
   [ Julien Lavergne ]
diff -Nru gdebi-0.9.5.7+nmu2/debian/control gdebi-0.9.5.7+nmu3/debian/control
--- gdebi-0.9.5.7+nmu2/debian/control	2017-12-31 16:55:07.000000000 +0100
+++ gdebi-0.9.5.7+nmu3/debian/control	2019-03-11 16:17:10.000000000 +0100
@@ -15,8 +15,6 @@
                intltool,
                xvfb,
                xauth,
-               pyflakes,
-               pyflakes3,
                lintian,
 X-Python3-Version: >= 3.3
 Standards-Version: 3.9.6
diff -Nru gdebi-0.9.5.7+nmu2/release_tests/test_pyflakes.py gdebi-0.9.5.7+nmu3/release_tests/test_pyflakes.py
--- gdebi-0.9.5.7+nmu2/release_tests/test_pyflakes.py	1970-01-01 01:00:00.000000000 +0100
+++ gdebi-0.9.5.7+nmu3/release_tests/test_pyflakes.py	2014-04-14 09:16:37.000000000 +0200
@@ -0,0 +1,24 @@
+import os
+import subprocess
+import unittest
+
+class TestPyflakesClean(unittest.TestCase):
+    """ ensure that the tree is pyflakes clean """
+
+    def setUp(self):
+        self.paths = [
+            os.path.join(os.path.dirname(__file__), ".."),
+            os.path.join(os.path.dirname(__file__), "..", "gdebi"),
+            os.path.join(os.path.dirname(__file__), "..", "gdebi-gtk"),
+            os.path.join(os.path.dirname(__file__), "..", "gdebi-kde"),
+            ]
+
+    def test_pyflakes_clean(self):
+        self.assertEqual(subprocess.check_call(['pyflakes'] + self.paths), 0)
+
+    def test_pyflakes3_clean(self):
+        self.assertEqual(subprocess.check_call(['pyflakes3'] +  self.paths), 0)
+
+
+if __name__ == "__main__":
+    unittest.main()
diff -Nru gdebi-0.9.5.7+nmu2/tests/test_pyflakes.py gdebi-0.9.5.7+nmu3/tests/test_pyflakes.py
--- gdebi-0.9.5.7+nmu2/tests/test_pyflakes.py	2014-04-14 09:16:37.000000000 +0200
+++ gdebi-0.9.5.7+nmu3/tests/test_pyflakes.py	1970-01-01 01:00:00.000000000 +0100
@@ -1,24 +0,0 @@
-import os
-import subprocess
-import unittest
-
-class TestPyflakesClean(unittest.TestCase):
-    """ ensure that the tree is pyflakes clean """
-
-    def setUp(self):
-        self.paths = [
-            os.path.join(os.path.dirname(__file__), ".."),
-            os.path.join(os.path.dirname(__file__), "..", "gdebi"),
-            os.path.join(os.path.dirname(__file__), "..", "gdebi-gtk"),
-            os.path.join(os.path.dirname(__file__), "..", "gdebi-kde"),
-            ]
-
-    def test_pyflakes_clean(self):
-        self.assertEqual(subprocess.check_call(['pyflakes'] + self.paths), 0)
-
-    def test_pyflakes3_clean(self):
-        self.assertEqual(subprocess.check_call(['pyflakes3'] +  self.paths), 0)
-
-
-if __name__ == "__main__":
-    unittest.main()

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe at debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://alioth-lists.debian.net/pipermail/ubuntu-dev-team/attachments/20190311/c7c1594b/attachment.sig>