[Yaird-devel] Bug#345067: ide-geenric inclusion even if it doesn't exist.

[Stephen Gran]

This one time, at band camp, Sven Luther said:
> Hi Erik, ...
> 
> I hope you have been fine, passed well into the  new year and in
> general had a good start of the year.
> 
> I am writing this to ask you to have a look at the patch in :
> 
>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=345067

Well, as you pointed out, this patch seems like a bad hack.  You're just
special casing one known broken architecture, rather than actually
addressing the real problem.  The real problem is that yaird fails when
it tries to modprobe a module that doesn't exist.

If it is reasonable to move on when a module that yaird thinks should be
loaded does not exist, then it seems to me that the better way to fix
this would be in Modprobe.pm and Base.pm.  First have modprobe.pm run
modprobe -l $module, and if !$rc, return something special (0? -1?,
"no-module"? whatever - just so it's not the same return code that
something else uses).  Then notice that case in the exec bit in Base.pm,
and don't raise a fatal error.

If that assumption is unreasonable (I honestly haen't looked at yaird
enough to know - I can imagine arguments both ways), then the fix would
be adding ide-generic to the module blacklist on the architectures where
it causes a problem.

It also seems to me that the best way to fix the via82cxxx module
needing ide-generic but not depending on it would also be in
Modprobe.pm.  There, you can just add 'insmod ide-generic' to @lines,
and it also seems the right place to test for it.

But again, I haven't looked at yaird enough to know if I'm missing
something.
-- 
 -----------------------------------------------------------------
|   ,''`.                                            Stephen Gran |
|  : :' :                                        sgran at debian.org |
|  `. `'                        Debian user, admin, and developer |
|    `-                                     http://www.debian.org |
 -----------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/yaird-devel/attachments/20060129/475a29af/attachment.pgp