[Yaird-devel] Bug#460814: Bug#460814: yaird: PATCH: get yaird working on 2.6.23 (BUG #443821)

[Jonas Smedegaard]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed, Jan 16, 2008 at 01:06:52AM +0100, Lubomir Host wrote:
>I'm sorry I have created new bugreport. I don't exactly know debian 
>bugtracking interface (it was my first attempt to submit bug with this 
>interface). Maybe I should read more documentation ... :-)

That's ok with me. I am just telling you, so you may do a better job 
next time - even without the tedious task of reading docs ;-) .


>> Also, it seems that your patch is done against plain ypstream yaird 
>> without the many other patches already applied to the package in 
>> Debian, and duplicating some of them.
>
>Patch has been done against Debian version of yaird, downloaded with 
>apt-get source yaird. So I think I have fresh sources.

Yes. This is a bit tricky: Some Debian packages apply patches as part of 
unpacking the source package, but the preferred method - which is used 
with yaird - is to store them as patches below debian/ and apply them as 
part of the build process.

The following would give you the source with Debian patches applied (but 
true, there was no way to easily guess that):

   fakeroot debian/rules apply-patches


>I think it is very easy to separate:
>
>- yaird-0.0.12/perl/Plan.pm part of diff is the first patch for newly
>  created bug http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=460818
>  (ignore non-root encrypted device with keyfile)
>
>- rest is the second patch for
>  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=443821

Well, it seems that the part of your patch that "fixed" bug#443821 for 
you was that you changed the error to a warning. The patch also changes 
IdeDev and InputTab parsing which seems unrelated, and at least the 
InputTab part was done already in another Debian patch.

Again, I tell you this to help you get a better understanding - as you 
may have noticed the bug is now fixed, using a different approach than 
the one you came up with.


Oh, and another small note: There's a shorter way to write the URL for 
bugreports: http://bugs.debian.org/443821 (and to get all bugs for the 
package: http://bugs.debian.org/yaird ).


Thanks for your help with this!


  - Jonas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHjeBAn7DbMsAkQLgRAshjAJwLHZ5E4JIfalJoXVIY5ORZNVTy9ACeKsaX
NieCiXen7CjkIe+m7vgOQiE=
=3Y5u
-----END PGP SIGNATURE-----