[Apt-listbugs-commits] [SCM] apt-listbugs development tree branch, master, updated. debian/0.1.1-34-g6406a78

Ryan Niebur ryanryan52 at gmail.com
Thu Dec 10 01:25:44 UTC 2009


The following commit has been merged in the master branch:
commit 809e7151794fffbac649eaceaba813c98eb0a1ee
Author: Francesco Poli (t1000) <frx at firenze.linux.it>
Date:   Tue Dec 8 21:42:44 2009 +0100

    fix apostrophe bug in preferences writing
    
    The gsub does not seem to be really needed.
    On the contrary, it seems to harm: when a package is pinned (inside
    the 'apt' command), an explanation is written to /etc/apt/preferences,
    including the bug number and title; if the bug title contains an
    apostrophe (an example is bug #558755) the explanation was messed up.
    Dropping the gsub fixes this issue.

diff --git a/debian/changelog b/debian/changelog
index cd298e1..05c1e32 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -13,8 +13,10 @@ apt-listbugs (0.1.2) UNRELEASED; urgency=low
   [ Francesco Poli (t1000) ]
   * added robustness checks to aptcleanup to cope with obsolete packages
   * dropped obsolete example update-index.db
+  * fixed bug in /etc/apt/preferences writing (bug titles with apostrophes
+    were messed up)
 
- -- Ryan Niebur <ryan at debian.org>  Sat, 07 Nov 2009 20:29:23 -0800
+ -- Francesco Poli (t1000) <frx at firenze.linux.it>  Tue, 08 Dec 2009 21:38:04 +0100
 
 apt-listbugs (0.1.1) unstable; urgency=low
 
diff --git a/lib/apt-listbugs/logic.rb b/lib/apt-listbugs/logic.rb
index 69f37bf..ba6738d 100644
--- a/lib/apt-listbugs/logic.rb
+++ b/lib/apt-listbugs/logic.rb
@@ -476,7 +476,7 @@ class Viewer
 Explanation: Pinned by apt-listbugs at #{Time.now}"
         bugs_of_pkg( bugs, pkg ).each { |bug|
 	  holdstr << "
-Explanation:   ##{bug.bug_number}: #{bug.desc.gsub("'","\\'")}"
+Explanation:   ##{bug.bug_number}: #{bug.desc}"
         }
 	holdstr << "
 Package: #{pkg}

-- 
apt-listbugs development tree



More information about the Apt-listbugs-commits mailing list