[Apt-listbugs-commits] [SCM] apt-listbugs development tree branch, master, updated. apt-listbugs/0.1.5-21-gca683b2

[Francesco Poli (wintermute)]

The following commit has been merged in the master branch:
commit 7d9d05e08951841aedf21f6923fcba9ab090d9fd
Author: Francesco Poli (wintermute) <invernomuto at paranoici.org>
Date:   Thu Dec 8 19:01:44 2011 +0100

    improve comments in test_am_i_buggy

diff --git a/debian/changelog b/debian/changelog
index 087862f..0f65e4e 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -16,7 +16,7 @@ apt-listbugs (0.1.6) UNRELEASED; urgency=low
     currently ignores the "affects" BTS field
   * added more assertions to the first test suite
 
- -- Francesco Poli (wintermute) <invernomuto at paranoici.org>  Thu, 08 Dec 2011 17:55:34 +0100
+ -- Francesco Poli (wintermute) <invernomuto at paranoici.org>  Thu, 08 Dec 2011 19:00:18 +0100
 
 apt-listbugs (0.1.5) unstable; urgency=low
 
diff --git a/test_logic.rb b/test_logic.rb
index ec58178..3ff1205 100755
--- a/test_logic.rb
+++ b/test_logic.rb
@@ -123,6 +123,7 @@ class TC_BugsFactory < Test::Unit::TestCase
     # c)  ----------------V------o-----------  non-buggy
     # d)  ----------------V------o----x------  non-buggy
     # e)  ----------------V------x----o------  buggy
+    # e') ----------------V-----(xo)---------  buggy
     # f)  ----------o-----V--- ? -- ? -- ? --  buggy
     # g)  ----------x-----V--- ? -- ? -- ? --  non-buggy
     # h)  -----o----x-----V--- ? -- ? -- ? --  non-buggy
@@ -165,17 +166,17 @@ class TC_BugsFactory < Test::Unit::TestCase
                  Factory::BugsFactory.am_i_buggy(
                                                  "3",
                                                  ["4"].join(" "), # fixed
-                                                 ["4"].join(" ")  # found
+                                                 ["5"].join(" ")  # found
                                                  ),
-                 "d')  ----------------V----------(xo)------  ? buggy")
+                 "e)  ----------------V------x----o------  buggy")
 
     assert_equal(true,
                  Factory::BugsFactory.am_i_buggy(
                                                  "3",
                                                  ["4"].join(" "), # fixed
-                                                 ["5"].join(" ")  # found
+                                                 ["4"].join(" ")  # found
                                                  ),
-                 "e)  ----------------V------x----o------  buggy")
+                 "e') ----------------V-----(xo)---------  buggy")
 
     assert_equal(true,
                  Factory::BugsFactory.am_i_buggy(
@@ -209,14 +210,13 @@ class TC_BugsFactory < Test::Unit::TestCase
                                                  ),
                  "i)  -----x----o-----V--- ? -- ? -- ? --  buggy")
 
-    # is this a bug?
     assert_equal(true,
                  Factory::BugsFactory.am_i_buggy(
                                                  "1.5",
                                                  ["apt-test/2.0", "apt-test/3.5"].join(" "), # fixed
                                                  ["apt-test/1.5", "apt-test/3.0"].join(" ")  # found
                                                  ),
-                 "Test a case for buggy package")
+                 "Bug is found right now")
 
     assert_equal(false,
                  Factory::BugsFactory.am_i_buggy(
@@ -224,7 +224,7 @@ class TC_BugsFactory < Test::Unit::TestCase
                                                  ["apt-test/2.0", "apt-test/3.5"].join(" "), # fixed
                                                  ["apt-test/1.5", "apt-test/3.0"].join(" ")  # found
                                                  ),
-                 "Test a case for non-buggy package")
+                 "Bug is fixed right now")
 
     assert_equal(false,
                  Factory::BugsFactory.am_i_buggy(
@@ -232,39 +232,39 @@ class TC_BugsFactory < Test::Unit::TestCase
                                                  ["apt-test/2.0", "apt-test/3.5"].join(" "), # fixed
                                                  ["apt-test/1.5", "apt-test/3.0"].join(" ")  # found
                                                  ),
-                 "Test case for ooooold package which is before bug is initially found")
+                 "Bug is found and then fixed multiple times in the future")
 
     assert_equal(true,
                  Factory::BugsFactory.am_i_buggy(
                                                  "1.0",
-                                                 "apt-test/2.0", #fixed
-                                                 nil #found
+                                                 "apt-test/2.0", # fixed
+                                                 nil # found
                                                  ),
-                 "Test case for package which bug is found in ancient day and fixed sometime in the future.")
+                 "Bug is fixed sometime in the future")
 
     assert_equal(false,
                  Factory::BugsFactory.am_i_buggy(
                                                  "3.0",
                                                  "apt-test/2.0", # fixed
-                                                 nil #found
+                                                 nil # found
                                                  ),
-                 "Test case for package which bug is found in ancient day and fixed sometime in the past.")
+                 "Bug is fixed sometime in the past")
 
     assert_equal(true,
                  Factory::BugsFactory.am_i_buggy(
                                                  "3.0",
-                                                 nil,
-                                                 "apt-test/1.0"
+                                                 nil, # fixed
+                                                 "apt-test/1.0" # found
                                                  ),
-                 "Test case for package which bug is found and no fixed date is set.")
+                 "Bug is found in the past, but never fixed")
 
     assert_equal(false,
                  Factory::BugsFactory.am_i_buggy(
                                                  "3.0",
-                                                 "4.0", #fixed
-                                                 "3.5" #found
+                                                 "4.0", # fixed
+                                                 "3.5" # found
                                                  ),
-                 "Bug is found and fixed in a future version")
+                 "Bug is found and then fixed in the future")
 
   end
 

-- 
apt-listbugs development tree