[Apt-listbugs-commits] [SCM] apt-listbugs development tree branch, master, updated. apt-listbugs/0.1.5-21-gca683b2

Francesco Poli (wintermute) invernomuto at paranoici.org
Sat Dec 10 17:02:49 UTC 2011


The following commit has been merged in the master branch:
commit 132a9ba42afae0abd6ea8c69e6cdabfbc73cbcac
Author: Francesco Poli (wintermute) <invernomuto at paranoici.org>
Date:   Fri Dec 9 18:38:36 2011 +0100

    improve comments in test_bug_is_irrelevant[_list]

diff --git a/debian/changelog b/debian/changelog
index cca66ac..12953ca 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -18,7 +18,7 @@ apt-listbugs (0.1.6) UNRELEASED; urgency=low
   * enhanced the (theoretical) correctness of the code to check whether a
     bug is present in a package version
 
- -- Francesco Poli (wintermute) <invernomuto at paranoici.org>  Fri, 09 Dec 2011 17:29:08 +0100
+ -- Francesco Poli (wintermute) <invernomuto at paranoici.org>  Fri, 09 Dec 2011 18:33:35 +0100
 
 apt-listbugs (0.1.5) unstable; urgency=low
 
diff --git a/test_logic.rb b/test_logic.rb
index 6caf17b..1ecd622 100755
--- a/test_logic.rb
+++ b/test_logic.rb
@@ -335,17 +335,16 @@ class TC_BugsFactory < Test::Unit::TestCase
   end
 
   def test_bug_is_irrelevant
-    # bug should be 'true' if that is non-relevant i.e. non-embugging
+    # bug_is_irrelevant() returns true if the bug can be ignored
 
     assert_equal(true,
-                 # returns true if this bug can be ignored
                  Factory::BugsFactory.bug_is_irrelevant("apt-test",
                                                         "1.5", "2.0",
                                                         123456,
                                                         ["apt-test/2.0", "apt-test/3.5"].join(" "), # fixed
                                                         ["apt-test/1.5", "apt-test/3.0"].join(" ")  # found
                                                         ),
-                 "test that normal case where upgrade fixes a bug.")
+                 "upgrade that fixes a bug")
 
     assert_equal(true,
                  Factory::BugsFactory.bug_is_irrelevant("apt-test",
@@ -354,7 +353,7 @@ class TC_BugsFactory < Test::Unit::TestCase
                                                         ["apt-test/2.0", "apt-test/3.5"].join(" "), # fixed
                                                         ["apt-test/1.5", "apt-test/3.0"].join(" ")  # found
                                                         ),
-                 "test the case where upgrade skips over a bug-period")
+                 "upgrade that skips over a bug region")
 
     assert_equal(true,
                  Factory::BugsFactory.bug_is_irrelevant("apt-test",
@@ -363,7 +362,7 @@ class TC_BugsFactory < Test::Unit::TestCase
                                                         ["apt-test/2.0", "apt-test/3.5"].join(" "), # fixed
                                                         ["apt-test/1.5", "apt-test/3.0"].join(" ")  # found
                                                         ),
-                 "Test the case where the latest upgrade fixes a bug")
+                 "latest upgrade that fixes a bug")
 
 
     assert_equal(false,
@@ -373,7 +372,7 @@ class TC_BugsFactory < Test::Unit::TestCase
                                                         ["apt-test/2.0", "apt-test/3.5"].join(" "), # fixed
                                                         ["apt-test/1.5", "apt-test/3.0"].join(" ")  # found
                                                         ),
-                 "Test the case where the latest upgrade introduces a bug")
+                 "latest upgrade that introduces a bug")
 
 
     assert_equal(false,
@@ -383,7 +382,7 @@ class TC_BugsFactory < Test::Unit::TestCase
                                                         ["apt-test/2.0", "apt-test/3.5"].join(" "), # fixed
                                                         ["apt-test/1.5", "apt-test/3.0"].join(" ")  # found
                                                         ),
-                 "test the case where upgrade jumps from non-buggy to reopened buggy")
+                 "upgrade that jumps from non-buggy to reopened buggy")
 
     assert_equal(false,
                  Factory::BugsFactory.bug_is_irrelevant("apt-test",
@@ -392,16 +391,16 @@ class TC_BugsFactory < Test::Unit::TestCase
                                                         ["apt-test/2.0", "apt-test/3.5"].join(" "), # fixed
                                                         ["apt-test/1.5", "apt-test/3.0"].join(" ")  # found
                                                         ),
-                 "test the case where upgrade jumps into a bug region")
+                 "upgrade that jumps into a bug region")
 
     assert_equal(true,
                  Factory::BugsFactory.bug_is_irrelevant("audacious",
                                                         "1.5.0-1", "1.5.0-2",
-                                                        123456,
-                                                        "",
+                                                        485109,
+                                                        nil, # fixed
                                                         ["audacious/1.4.6-2", "audacious/1.5.0-2"].join(" ")  # found
                                                         ),
-                 "between two found versions, and I am already buggy in the previous installation, #485109")
+                 "upgrade that jumps to a found version from an already buggy version")
 
     assert_equal(true,
                  Factory::BugsFactory.bug_is_irrelevant("apt-test",
@@ -410,7 +409,7 @@ class TC_BugsFactory < Test::Unit::TestCase
                                                         ["apt-test/2.0", "apt-test/3.5"].join(" "), # fixed
                                                         ["apt-test/1.5", "apt-test/3.0"].join(" ")  # found
                                                         ),
-                 "test the case where upgrade jumps from buggy-buggy")
+                 "upgrade that jumps from buggy to buggy")
 
     assert_equal(false,
                  Factory::BugsFactory.bug_is_irrelevant("apt-test",
@@ -419,7 +418,7 @@ class TC_BugsFactory < Test::Unit::TestCase
                                                         ["apt-test/2.0", "apt-test/3.5"].join(" "), # fixed
                                                         ["apt-test/1.5", "apt-test/3.0"].join(" ")  # found
                                                         ),
-                 "test new install into buggy version")
+                 "new installation of a buggy version")
 
     assert_equal(true,
                  Factory::BugsFactory.bug_is_irrelevant("apt-test",
@@ -428,7 +427,7 @@ class TC_BugsFactory < Test::Unit::TestCase
                                                         ["apt-test/2.0", "apt-test/3.5"].join(" "), # fixed
                                                         ["apt-test/1.5", "apt-test/3.0"].join(" ")  # found
                                                         ),
-                 "test new install into non-buggy version")
+                 "new installation of a non-buggy version")
 
     assert_equal(false,
                  Factory::BugsFactory.bug_is_irrelevant("perl",
@@ -437,37 +436,37 @@ class TC_BugsFactory < Test::Unit::TestCase
                                                         nil, # fixed
                                                         ["perl/5.10.0-11"].join(" ")  # found
                                                         ),
-                 "Test an upgrade to a newly found unfixed bug.")
+                 "upgrade to a newly found unfixed bug")
 
     assert_equal(true,
                  Factory::BugsFactory.bug_is_irrelevant("apt",
                                                         "0.7.14", nil,
                                                         482476,
-                                                        nil,
-                                                        ["apt/0.7.11", "apt/0.6.46.4-0.1"].join(" "),  # found
+                                                        nil, # fixed
+                                                        ["apt/0.7.11", "apt/0.6.46.4-0.1"].join(" "), # found
                                                         "done"
                                                         ),
-                 "Say this bug is 'done' without version info")
+                 "bug which is 'done' without fixed version info")
 
     assert_equal(false,
                  Factory::BugsFactory.bug_is_irrelevant("apt",
                                                         "0.7.14", nil,
                                                         482476,
-                                                        "0.7.15",
-                                                        ["apt/0.7.11", "apt/0.6.46.4-0.1"].join(" "),  # found
+                                                        "0.7.15", # fixed
+                                                        ["apt/0.7.11", "apt/0.6.46.4-0.1"].join(" "), # found
                                                         "done"
                                                         ),
-                 "Say this bug is 'done' with version info")
+                 "bug which is 'done' with fixed version info")
 
     assert_equal(true,
                  Factory::BugsFactory.bug_is_irrelevant("apt-test",
                                                         "0.1", "0.2",
                                                         4321,
-                                                        "0.5", #fixed
-                                                        "0.3",  # found
+                                                        "0.5", # fixed
+                                                        "0.3", # found
                                                         "done"
                                                         ),
-                 "Test bug where bug is found and fixed in future version.")
+                 "bug which is found and fixed in future versions")
 
   end
 end
@@ -489,7 +488,7 @@ class TC_BugsFactory_List < Test::Unit::TestCase
                                                         ["apt-test/2.0", "apt-test/3.5"].join(" "), # fixed
                                                         ["apt-test/1.5", "apt-test/3.0"].join(" ")  # found
                                                         ),
-                 "test apt-listbugs list with buggy version")
+                 "apt-listbugs list with buggy version")
 
     assert_equal(true,
                  Factory::BugsFactory.bug_is_irrelevant("apt-test",
@@ -498,16 +497,16 @@ class TC_BugsFactory_List < Test::Unit::TestCase
                                                         ["apt-test/2.0", "apt-test/3.5"].join(" "), # fixed
                                                         ["apt-test/1.5", "apt-test/3.0"].join(" ")  # found
                                                         ),
-                 "test apt-listbugs list with non-buggy version")
+                 "apt-listbugs list with non-buggy version")
 
     assert_equal(true,
-                 Factory::BugsFactory.bug_is_irrelevant("apt-test",
+                 Factory::BugsFactory.bug_is_irrelevant("apt",
                                                         nil, "0.7.14+b1",
                                                         482476,
                                                         ["0.7.14"].join(" "), # fixed
                                                         ["apt/0.7.11", "apt/0.6.46.4-0.1"].join(" ")  # found
                                                         ),
-                 "test apt-listbugs list apt, apt bug is fixed")
+                 "apt-listbugs list apt/0.7.14+b1 which is fixed")
 
     assert_equal(true,
                  Factory::BugsFactory.bug_is_irrelevant("apt-test",
@@ -516,7 +515,7 @@ class TC_BugsFactory_List < Test::Unit::TestCase
                                                         ["apt-test/3.5"].join(" "), # fixed
                                                         ["apt-test/3.2"].join(" ")  # found
                                                         ),
-                 "Ignore bug that is found newer than this version")
+                 "bug that is found later than this version")
 
 
   end

-- 
apt-listbugs development tree



More information about the Apt-listbugs-commits mailing list