[Bash-completion-devel] Bug#504141: bash-completion: Improved known_hosts completion with -F support, hosts indented or comment-trailed

[David Paleino]

Hello Freddy,

On Sat, 01 Nov 2008 00:36:46 +0100, Freddy Vulto wrote:

> Attached are improvements to _known_hosts, ssh, scp and sftp:
> - Added support for `-F configfile' to _known_hosts.  I've done this
> especially to make it easier to configure an ssh testsuite when writing
> automated tests.

I'm committing those changes. However, I believe I found a typo in your
ssh/scp modifications:

+		    if [ ${#1} -gt 2 ]; then
+			optconfigfile="$i"
+		    else

Shouldn't that be $1, instead of $i? AFAICT, $i is not defined anywhere, while
$1 perfectly makes sense there.

Committed with these corrections in bzr rev1199.

> - Allow `Host(Name)' in ssh config file to be indented

Committed in bzr rev1200.

> - Allow `Host(Name)' in ssh config file to have trailing comment.  Note that
>   SSH allows a comment after `Host' but not after `HostName'.  In the latter
>   case you'll get an error message when trying to scp/ssh/sftp:
>   
>      garbage at end of line; "#".

Committed in bzr rev1201.


Thanks for helping us,
David

-- 
 . ''`.  Debian maintainer | http://wiki.debian.org/DavidPaleino
 : :'  : Linuxer #334216 --|-- http://www.hanskalabs.net/
 `. `'`  GPG: 1392B174 ----|---- http://snipr.com/qa_page
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/bash-completion-devel/attachments/20081101/e38c0f7b/attachment-0001.pgp