[Bash-completion-devel] Ubuntu bash-completion 20080705ubuntu2

[Colin Watson]

On Wed, Feb 04, 2009 at 10:37:20PM +0100, David Paleino wrote:
> On Wed, 04 Feb 2009 21:24:13 -0000, Ubuntu Merge-o-Matic wrote:
> > This e-mail has been sent due to an upload to Ubuntu that contains Ubuntu
> > changes.  It contains the difference between the new version and the
> > previous version of the same source package in Ubuntu.
> > 
> > [..]
> > Version: 20080705ubuntu2
> > [..]
> > Changed-By: Colin Watson <cjwatson at ubuntu.com>
> > [..]
> > Launchpad-Bugs-Fixed: 316654
> > Changes: 
> >  bash-completion (20080705ubuntu2) jaunty; urgency=low
> >  .
> >    * modprobe: Check for */* before checking for 'modprobe -r', to avoid
> >      spewing an awk syntax error (thanks, Martin Mai; LP: #316654).
> 
> Just FYI: this bug was already fixed upstream, and your fix is wrong:
> 
> ------------------------------------------------------------
> revno: 1290
> committer: Ville Skyttä <ville.skytta at iki.fi>
> branch nick: current
> timestamp: Sun 2009-01-25 23:40:44 +0200
> message:
>   Fix awk error in "modprobe -r /" completion, extract/use _installed_modules
> for rmmod and modprobe -r.
> ------------------------------------------------------------
> 
> You can find the patch attached. Please revert your change, merge this patch,
> and next time keep an eye on upstream development.

Oh, come on, give me a break! I already filed a bug
(http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=512556) with a bzr
bundle of the patch I applied, and Ville pointed out the (non-serious)
mistake *after* I uploaded that Ubuntu package. You hadn't fixed this
bug upstream at the time I made that upload. I'll certainly get round to
importing the proper fix into the Ubuntu package, but I don't really
appreciate being ticked off and told to keep an eye on upstream
development when I'm the one who reported the bug prompting the
(admittedly superior) upstream fix!

Don't be misled by the date on which Merge-o-Matic sent this mail to
you; I actually uploaded the package on 2009-01-21. I think
Merge-o-Matic was broken for a while there, and Scott only fixed it
yesterday.

-- 
Colin Watson                                       [cjwatson at ubuntu.com]