[Bash-completion-devel] Minicom completion misses local config - #315256 (with patch)

[Nevo Hed]

> 
> Hm, I don't remember seeing a mail about that, maybe the Alioth horror
> thingy has stopped sending them?

Must be something like that (any chance going to github *nervous-LisaSimpson-laugh*)


> Anyway, applied with minor tweaks.
Can you explain the tweak?
as far as I can see, spacing aside, there is a switch from testing & return

 From
   [[ ${#COMPREPLY[@]} -gt 0 ]] && return 0
To
   [[ $COMPREPLY ]] && return
  
Maybe I read too quickly but I could not correlate this to anything specific in the  CONTRIBUTING section
(except possibly “Read the existing source code for examples of how to solve particular problems”)

The former always sounds to me to be an explicit, less ambiguous, and those better bash test and as we are
not trying to go for compatibility with other shells I’m just slightly confused (not offended mind you)


> For future reference, contribution
> guidelines are documented in README's CONTRIBUTING section.

My bad - I guess I did see it weeks ago, but forgot about it when sending the ``bump'' message 

Thanks!
  —Nevo