[Bash-completion-devel] Minicom completion misses local config - #315256 (with patch)

[Ville Skyttä]

On Wed, Feb 10, 2016 at 2:46 AM, Nevo Hed
<nhed-debianorg15 at bsoftworks.com> wrote:
>
>> Anyway, applied with minor tweaks.
> Can you explain the tweak?
> as far as I can see, spacing aside, there is a switch from testing & return
>
>  From
>    [[ ${#COMPREPLY[@]} -gt 0 ]] && return 0
> To
>    [[ $COMPREPLY ]] && return
>
> Maybe I read too quickly but I could not correlate this to anything specific in the  CONTRIBUTING section
> (except possibly “Read the existing source code for examples of how to solve particular problems”)
>
> The former always sounds to me to be an explicit, less ambiguous, and those better bash test and as we are
> not trying to go for compatibility with other shells I’m just slightly confused (not offended mind you)

We don't have stuff documented to this detail level. But that's how
this particular check is done throughout the codebase, and in addition
to the consistency goodness, at least to me it's much more readable.