Bug#219132: [Build-common-hackers] upload

Robert Millan Robert Millan <zeratul2@wanadoo.es>, 219132@bugs.debian.org
Fri, 14 Nov 2003 10:53:02 +0100

On Thu, Nov 13, 2003 at 05:37:42PM -0500, Colin Walters wrote:
> > I have already looked at most of them. I'm not sure if #219132 should be 
> > applied: These "ifeq"s look strange to me, isn't that what "?=" is for? 
> Yeah.

Yep, my oversight. However, I just rewrote these lines yesterday in order
to make it work with multiple suffixes in DEB_PATCH_SUFFIX. It now looks

DEB_PATCH_SUFFIX ?= .patch .diff
DEB_PATCHDIRS ?= debian/patches
DEB_PATCHES = $(foreach suffix,$(DEB_PATCH_SUFFIX),\
        $(foreach dir,$(DEB_PATCHDIRS),\
        $(shell echo $(wildcard $(dir)/*$(suffix)))))

Could you use these lines instead? (the code is tested and known to work)

note: the .diff was moved from the last line in which it was hardcoded

> > Also can compressed patches be in debian/patches? This would mean binary 
> > files in the .diff.gz.
> Right; If I had to take a guess, he's planning on using this to override
> DEB_PATCHDIRS and point at some external set of patches that's already
> unpacked, or something.  Robert?

You guessed right. That explains the need for _READONLY option, too: my
package was either getting permission-errors (fakeroot) or trashing my system
directories (sudo).

Although you can still compress stuff in your debian/ dir if you use
debian-native packages (or dpkg-source v2).

Robert Millan

"[..] but the delight and pride of Aule is in the deed of making, and in the
thing made, and neither in possession nor in his own mastery; wherefore he
gives and hoards not, and is free from care, passing ever on to some new work."

 -- J.R.R.T, Ainulindale (Silmarillion)