Bug#305857: [Build-common-hackers] Bug#305857: ability to use uu-encoded patches

Robert Millan Robert Millan <rmh@debian.org>, 305857@bugs.debian.org
Wed, 18 May 2005 12:27:07 +0200


On Fri, Apr 22, 2005 at 10:43:51AM -0400, Christopher Martin wrote:
> Package: cdbs
> Tags: patch
> 
> Hello,
> 
> The following patch (inspired by Achim Bohnet) gives simple-patchsys.mk the 
> ability to handle uuencoded patches. Aside from applying the patch, you'd 
> simply have to add a Recommends for sharutils.
> 
> Please do apply the patch soon if it looks OK - uu-encoding is the easiest 
> way to ship binaries in a diff, and this ability is very important for KDE, 
> where branch updates often include new icons, etc.

Thanks for the patch!  I have a pair of questions:

  - Would it make sense to compress uuencoded patches?  If so, you missed the
    extension checks for *.uu.(gz|bz2)

  - Do we also need this for dpatch.mk ?

> --- cdbs.orig/simple-patchsys.mk
> +++ cdbs.patched/simple-patchsys.mk
> @@ -35,7 +35,7 @@
>  _cdbs_patch_system_apply_rule := apply-patches
>  _cdbs_patch_system_unapply_rule := reverse-patches
>  
> -DEB_PATCH_SUFFIX ?= .diff .diff.gz .diff.bz2 .patch .patch.gz .patch.bz2 
> +DEB_PATCH_SUFFIX ?= .diff .diff.gz .diff.bz2 .diff.uu .patch .patch.gz .patch.bz2 .patch.uu
>  DEB_PATCHDIRS ?= debian/patches
>  close_parenthesis ?= )
>  DEB_PATCHES := $(shell\
> @@ -86,6 +86,7 @@
>            case $$patch in \
>              *.gz) cat=zcat ;; \
>              *.bz2) cat=bzcat ;; \
> +            *.uu) cat="uudecode -o -" ;; \
>              *) cat=cat ;; \
>            esac; \
>  	  level=$$(head $$patch | egrep '^#DPATCHLEVEL=' | cut -f 2 -d '='); \


-- 
 .''`.   Proudly running Debian GNU/kFreeBSD unstable/unreleased (on UFS2+S)
: :' :
`. `'    http://www.debian.org/ports/kfreebsd-gnu
  `-