[Build-common-hackers] Bug#287157: #287157 - An example to this bug

[Peter Eisentraut]

Nelson A. de Oliveira wrote:
> The makefile sets a CFLAGS containing this:
>
> CFLAGS = -I$(ZDIR) -I$(PNGDIR) -Wall $(CRELEASE)
>
> Since CDBS passes CFLAGS="-g -Wall -O2", it overrides the CFLAGS
> included on the source code, making the package fail to build.

Makefiles written in this way are broken -- at least with respect to 
common build system practices.  There are packages on the other hand 
that do it correctly, namely set CFLAGS in the makefiles expecting them 
to be overridden if desired on the command line, and if we made the 
change that is proposed in this bug we would break those packages.