[Build-common-hackers] Bug#287157: #287157 - An example to this bug
Nelson A. de Oliveira
naoliv at gmail.com
Tue Feb 14 02:40:35 UTC 2006
-----BEGIN PGP SIGNED MESSAGE-----
Peter Eisentraut wrote:
> Nelson A. de Oliveira wrote:
>>The makefile sets a CFLAGS containing this:
>>CFLAGS = -I$(ZDIR) -I$(PNGDIR) -Wall $(CRELEASE)
>>Since CDBS passes CFLAGS="-g -Wall -O2", it overrides the CFLAGS
>>included on the source code, making the package fail to build.
> Makefiles written in this way are broken -- at least with respect to
> common build system practices. There are packages on the other hand
> that do it correctly, namely set CFLAGS in the makefiles expecting them
> to be overridden if desired on the command line, and if we made the
> change that is proposed in this bug we would break those packages.
Good. I have contacted the upstream author of this program and sent him
a patch to fix this issue.
About this bug, maybe tags it wont-fix, so people will see that actually
it's not a bug on CDBS? (if we left it open, people can think that
nothing is being done about this and if we close the bug, someone can
open another similar bug later). Just a suggestion.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
-----END PGP SIGNATURE-----
More information about the Build-common-hackers