[Build-common-hackers] Bug#494254: cdbs: please clean before unpatch (revert bug #387103)

[Steve Langasek]

Package: cdbs
Version: 0.4.52
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch intrepid

Hi,

In cdbs 0.4.48, simple-patchsys.mk was changed to unapply patches before
cleaning the build directory, in response to bug #387103.  Objections were
raised at the time that this wasn't the right thing to do; that the correct
sequence was to unpatch after clean, but to skip the unpatch when using
tarball.mk.

Then in bug #424080, the package was changed so that tarball.mk *did* skip
the unpatching; but the unpatching is still being done before clean rather
than after.

This is simply wrong, because it means simple-patchsys.mk doesn't work
correctly when you have to patch the build system in a way that affects the
outcome of, e.g., 'make distclean'.

I believe the attached patch, to revert this behavior, is correct and should
be applied.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cdbs-clean-before-unpatch.diff
Type: text/x-diff
Size: 1112 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/build-common-hackers/attachments/20080807/bb8fe91a/attachment.diff