[Build-common-hackers] a WAF class for CDBS

[Jonas Smedegaard]

On Tue, Dec 28, 2010 at 11:10:43AM +0100, Rémi Thebault wrote:
>Hi Jonas
>
>Le lundi 27 décembre 2010 à 00:59 +0100, Jonas Smedegaard a écrit :
>
>> On Mon, Dec 27, 2010 at 12:16:02AM +0100, Rémi Thebault wrote:
>> >Le samedi 25 décembre 2010 à 22:18 +0100, Jonas Smedegaard a écrit :
>> >> I recommend to support global, package-default and per-package 
>> >> vars
>> >
>> >I use $(cdbs_curdestdir) in common-install-impl target. I tried 
>> >something with calling cdbs_expand_curvar, but no success. the var 
>> >isn't expanded as I expected. I commented out for the moment
>>
>> Perhaps if you elaborate on what you tried, I can help figure out 
>> what went wrong - and we can learn if something is broken or you 
>> misunderstood how to use it.  In other words: maybe documentation 
>> just needs to be improved :-)
>
>
>I just commited for this. In my test package:
>if I set DEB_WAF_OPTIONS : no effect
>if I set DEB_WAF_OPTIONS_ALL : works
>if I set DEB_WAF_OPTIONS_DEFAULT : works
>if I set DEB_WAF_OPTIONS_pkgname : no effect (it is a single package,
>could be the cause)
>
>Is this behaviour correct or something is wrong in the snippet ?
>I would have at least expected VAR to be expanded.

This is intended behavour.

The first one works too for most older snippets, but with a warning that 
it is deprecated.

The last one (with pkgname replaced with the actual binary package name) 
works only in per-package targets, i.e. a construct like this:

build/foopackage
	$(DEB_WAF_INVOKE) $(DEB_WAF_BUILD_TARGET) $(DEB_WAF_OPTIONS)


Hope that helps,

  - Jonas

-- 
  * Jonas Smedegaard - idealist & Internet-arkitekt
  * Tlf.: +45 40843136  Website: http://dr.jones.dk/

  [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/build-common-hackers/attachments/20101228/8af999ac/attachment-0001.pgp>