[Build-common-hackers] a WAF class for CDBS

[Jonas Smedegaard]

On Tue, Dec 28, 2010 at 11:10:43AM +0100, Rémi Thebault wrote:
>Hi Jonas
>
>Le lundi 27 décembre 2010 à 00:59 +0100, Jonas Smedegaard a écrit :
>
>> On Mon, Dec 27, 2010 at 12:16:02AM +0100, Rémi Thebault wrote:
>> >Le samedi 25 décembre 2010 à 22:18 +0100, Jonas Smedegaard a écrit :
>> >> I recommend to support global, package-default and per-package 
>> >> vars
>> >
>> >I use $(cdbs_curdestdir) in common-install-impl target. I tried 
>> >something with calling cdbs_expand_curvar, but no success. the var 
>> >isn't expanded as I expected. I commented out for the moment
>>
>> Perhaps if you elaborate on what you tried, I can help figure out 
>> what went wrong - and we can learn if something is broken or you 
>> misunderstood how to use it.  In other words: maybe documentation 
>> just needs to be improved :-)
>
>
>I just commited for this.

Well, you did the change for DEB_WAF_OPTIONS and 
DEB_WAF_CONFIGURE_OPTIONS - I suggest to do it for the other vars too.

And I recommend to list user-editable (i.e. capitalized DEB_*) variables 
before internal (i.e. lowercased cdbs_*).  And more generally (although 
possibly irrelevant for this waf snippet) order by interdependency so 
that vars are listed before any use of it.  This is just for clarity, 
make will manage even if "wrongly" ordered (as long as not set directly 
applied using := construct).


  - Jonas

-- 
  * Jonas Smedegaard - idealist & Internet-arkitekt
  * Tlf.: +45 40843136  Website: http://dr.jones.dk/

  [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/build-common-hackers/attachments/20101228/3dd57180/attachment.pgp>