[Buildd-tools-devel] Bug#477937: Bug#477937: double check for repo type

[martin f krafft]

also sprach Roger Leigh <rleigh at whinlatter.ukfsn.org> [2008.04.29.1922 +0400]:
> This is still a little hacky.

Less so than my approach¸ anyway.

> This is where writing the chroot_git class would make things
> a little nicer--it would allow customisation directly in
> schroot.conf with extra keys, and set them up in the environment
> for the setup scripts to use.

All I am saying is that why make this specific to git? Why can't
file and git and whatever else might be created not be handled by
chroot_custom, which is instantiated when no better chroot type
handler exists. It sets $CHROOT_TYPE according to what type=
parameter says and populates the environment with any additional
parameters in schroot.conf. Now it's up to 05file, 05git, 05whatever
to set up the chroot. If I wanted to add 05hg or 05bzr, I could,
without any hacks or C++ hackery.

-- 
 .''`.   martin f. krafft <madduck at debian.org>
: :'  :  proud Debian developer, author, administrator, and user
`. `'`   http://people.debian.org/~madduck - http://debiansystem.info
  `-  Debian - when you have better things to do than fixing systems
 
"nothing can cure the soul but the senses,
 just as nothing can cure the senses but the soul."
                                                        -- oscar wilde
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature (see http://martin-krafft.net/gpg/)
Url : http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20080430/f62d1466/attachment.pgp