[Buildd-tools-devel] Bug#477937: Bug#477937: Bug#477937: double check for repo type

[Roger Leigh]

On Wed, Apr 30, 2008 at 11:57:49AM +0400, martin f krafft wrote:
> also sprach Roger Leigh <rleigh at whinlatter.ukfsn.org> [2008.04.29.1922 +0400]:
> > This is still a little hacky.
> 
> Less so than my approach¸ anyway.
> 
> > This is where writing the chroot_git class would make things
> > a little nicer--it would allow customisation directly in
> > schroot.conf with extra keys, and set them up in the environment
> > for the setup scripts to use.
> 
> All I am saying is that why make this specific to git? Why can't
> file and git and whatever else might be created not be handled by
> chroot_custom, which is instantiated when no better chroot type
> handler exists. It sets $CHROOT_TYPE according to what type=
> parameter says and populates the environment with any additional
> parameters in schroot.conf. Now it's up to 05file, 05git, 05whatever
> to set up the chroot. If I wanted to add 05hg or 05bzr, I could,
> without any hacks or C++ hackery.

Ah, I see where you are coming from.  This would be quite possible to
do.  The configuration would be somewhat harder to validate than what is
currently allowed (we would probably just s/[a-z]/[A-Z]/ and s/-/_/ to
upcase and convert - to _.  The names would have to be valid shell
variables.

I'll certainly look at adding this--it shouldn't be too much work.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.