[buildd-tools-devel] Cleanup patches for current schroot tip

Jan-Marek Glogowski glogow at fbihome.de
Mon Aug 10 18:12:09 UTC 2009


Hi everybody

The following patchset contains my union-fixes branch for the current schroot
tip. Patches 01, 02, 03 and 06 are real cleanup patches. Patch 05 just prints
some additional information for testsuite failures.

[PATCH 01/11] [union] Cleanup union handling in scripts
[PATCH 02/11] [union] Really use own error messages
[PATCH 03/11] [.gitignore] Add VERSION and .gdb_history
[PATCH 05/11] [test] Print key and value for keyfile and env
[PATCH 06/11] [test] Cleanup keyfile and environment tests

I didn't test 04, since I don't have a block-device chroot with union support,
but it seems to be an obvious fix.

[PATCH 04/11] [block-device-base] Don't lock union block devices

Please have a special look at patches 07 and 10, which both add some 
documentation - I'm no native english speaker.

[PATCH 07/11] [schroot-options] Clarify --session-name usage
[PATCH 10/11] [doc] Fix some doxygen class headers

I tested my run-parts(8) binary and it skips hidden files, so should schroot
do, which could otherwise introduce a lot of confusion:

[PATCH 08/11] [run-parts,chroot-config] Skip hidden files

I still need to revert a8d228256539e5f9a5f71a08de06757c6e4b586e, otherwise I
get depricated key messages from my union chroots:

W: Zeile 10 [dev]: Missbilligtes Schlüsselwort »source-root-groups« wurde verwendet
I: This option will be removed in the future; please update your configuration     
W: Zeile 10 [loopback]: Missbilligtes Schlüsselwort »source-root-groups« wurde verwendet
I: This option will be removed in the future; please update your configuration

[PATCH 11/11] Revert "facet_session: Move deserialisation code"

Finally the largest patch, which drops chroot-source-clonable and instead
simply drops the source facet, if the chroot is not clonable.
I just pulled and got the sbuild-chroot-facet-session-clonable changes, which
basically introduced an empty sbuild-chroot-facet-session, so I guess this
could be changed to drop the session facet instead. 

[PATCH 09/11] [chroot-source] Cleanup clonable handling

The weekend I checked all my previous schroot branches to collect some of my
old ideas and ported them to the current tip. This includes:

  * a chroot "container" member
  * verify configs and sessions by stat'ing the containers and skip missing
    ones for lists
  * drop chroot specific container handling (file, device, directory)
  * ignore missing schroot.conf, if there are chroots defined in chroot.d
  * don't rollback non-run scripts for automatic sessions

I'll resent the stuff after the 1.3.0 release, except the rollback patch.

Regards,
Jan-Marek




More information about the Buildd-tools-devel mailing list