[buildd-tools-devel] Cleanup patches for current schroot tip

[Roger Leigh]

On Mon, Aug 10, 2009 at 08:12:09PM +0200, Jan-Marek Glogowski wrote:
> The following patchset contains my union-fixes branch for the current schroot
> tip. Patches 01, 02, 03 and 06 are real cleanup patches. Patch 05 just prints
> some additional information for testsuite failures.
> 
> [PATCH 01/11] [union] Cleanup union handling in scripts
> [PATCH 02/11] [union] Really use own error messages
> [PATCH 03/11] [.gitignore] Add VERSION and .gdb_history
> [PATCH 05/11] [test] Print key and value for keyfile and env
> [PATCH 06/11] [test] Cleanup keyfile and environment tests
> 
> I didn't test 04, since I don't have a block-device chroot with union support,
> but it seems to be an obvious fix.

> [PATCH 04/11] [block-device-base] Don't lock union block devices

All the above six patches have been applied.  Thanks!

> [PATCH 07/11] [schroot-options] Clarify --session-name usage

This is something I'm currently working on on the session-separation
branch: http://git.debian.org/?p=users/rleigh/schroot.git;a=shortlog;h=refs/heads/session-separation

Currently all chroots live in a single namespace.  This splits source
and session chroots into separate namespaces, so you can refer to them
unambiguously.  Additionally, you can have the same name in each
namespace (so source chroots can have the same name as the regular
chroot, allowing dropping of the -source suffix, though it can also be
kept for backward compatibility if needed).

Different commands can use the namespace related to that command:

automatic session: chroot
  (--source or --session modifiers could be added to select the
   namespace for the --chroot option)
begin session: chroot
run session: session
end session: session

--list/--info/--config and other commands that operate on groups of
chroots are a little more ambiguous.  Here we probably want to list
everything matching in all namespaces.  The --all options will just
select entire namespaces, and --all-sources will also be added.

I'm not totally sure of the best option naming and use here, so any
comments welcome.  This should make the code quite a bit simpler!
The changes to the internals are/will be straightforward; it's just
finding the best way to present this to the user as options, with
the least incompatibility with earlier versions.

This is also to correct the inconsistencies reported in #512131
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=512131

> [PATCH 10/11] [doc] Fix some doxygen class headers
> 
> I tested my run-parts(8) binary and it skips hidden files, so should schroot
> do, which could otherwise introduce a lot of confusion:

It should already be skipping hidden files in any case, since the
files need to be checked with is_valid_filename(), and none of the
patterns allow a leading dot.

[...]

Got to get some sleep now, so I'll get to the remainder tomorrow!


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20090810/d8a435a0/attachment.pgp>