[buildd-tools-devel] Bug#568187: Bug#568187: Bug#568187: schroot -i segfaults on leftovers in /var/lib/schroot/session/

[Roger Leigh]

tags 568187 + patch fixed-upstream pending
thanks

On Thu, Feb 04, 2010 at 12:46:57AM +0100, Marc Bantle wrote:
> Roger Leigh schrieb:
> > Could you possibly let me know what file was in
> > /var/lib/schroot/session/, and if you have it, the contents?
> >   
> Find file attached (
> > Can you reproduce the problem again?  
> Yes, every time when the given file is in /var/lib/schroot/session/
> > If so, could you take me through
> > the steps to cause a file to be left in the session directory.  
> Unfortunately not, that happend accidentally. I didn't
> set the 'type' parameter on previous configurations. Maybe
> that caused it.

Thanks for the file and debugging info.  I've been able to reproduce
the problem and correct it using the attached patch.

The loader code creates a "template" chroot of the desired type,
and then clones a session chroot from this in order to restore the
configuration.  plain chroot types, however, don't support session
cloning and return a NULL chroot which leads to the segfault when
we try to use it.  The patch adds an additional check to ensure we
only do this when working with a clonable chroot type.

This should be in a new release shortly.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: schroot-load-session-segfault.patch
Type: text/x-diff
Size: 1184 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20100205/633f5166/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20100205/633f5166/attachment.pgp>