[buildd-tools-devel] Bug#583504: Bug#583504: schroot: non-uuid formatted chroot names do not work with lvm snapshots

[Roger Leigh]

On Thu, May 27, 2010 at 02:22:31PM -0700, Zach Carter wrote:
> Package: schroot
> Version: 1.4.2
> Severity: normal
> 
> When compiled without uuid support, schroot creates chroot names that include 
> colon characters in them.  When creating a snapshot based on those names, the 
> lvcreate command fails like this:
> 
> E: 05lvm:   Logical volume name "f12-2010-05-27T20:35:13Z-12237" is invalid
> 
> Recommendation: when uuid support is not available, convert the colon 
> characters to some other allowable character, such as underscore '_'.
> 
> Alternatively, another suggestion would be to modify the autotools to require 
> uuid support.

Thanks for reporting this.  This is due to using the isodate() function
from  sbuild/sbuild-types.h to get a formatted date(+pid) in place of
the UUID.  It looks like using this is inappropriate due to the extra
formatting; switching to time(2) to get the time in seconds is
sufficient for this to work, and will not break lvcreate.  I'll do this
ASAP.

Regarding requiring uuid support, this alternative behaviour is to
allow use on systems without support, and I'd prefer to keep it
optional for this reason.  On platforms with UUID support, it will
be autodetected and used if present (this is already in configure.ac
script).


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20100530/75114c47/attachment.pgp>