[buildd-tools-devel] Bug#626361: Bug#626361: run lintian and piuparts from within the chroot

[Reinhard Tartler]

On Wed, May 11, 2011 at 12:23:43 (CEST), Roger Leigh wrote:

> On Wed, May 11, 2011 at 11:46:56AM +0200, Reinhard Tartler wrote:
>> Thanks for implementing the --run-lintian and --run-piuparts hooks in
>> sbuild. I noticed that both swtiches try to use the system utilities. I
>> think it would be far more useful if they would install the packages in
>> the chroot and use them right inside the chroot. Imagine the case that
>> you have several chroots (oldstable, unstable, testing, lucid, natty,
>> etc), where using the system lintian from debian/stable might not give
>> the best results.  In case you used the tool versions from the chroot,
>> always the matching version of these QA are used and you get better
>> reports.
>
> This shouldn't be a problem--it's just a matter of adding them
> to the dependency list and running them after the build.

Well, with this approach, the package wouldn't be built in a "clean"
chroot any longer but in a chroot with a couple of extra packages. The
dependency list of lintian and piuparts are both quite large.

I'm not aware of any packages that expose problems with that, but it
might be better to have the builds behave the same regardless if
lintian/piuparts is installed/used or not.

> Does piuparts need any extra setup e.g. a chroot inside the chroot
> to do its install and purge tests?  If it's all handled automatically
> by the package postinst that's fine, and for efficiency it can be
> installed in the source chroot so that it's not installed and set up
> for every build.

AFAIUI not. in this mode of operation, I think it makes sense to
recreate the chroot in which the built packages are tested from
scratch. It needs to run with root priviledges, though.

Thinking a bit more of that, at least for session chroots it might make
sense to change piuparts to not test in an extra testing-chroot, but
directly in sbuild's build-chroot. But probably only for session managed
chroots.

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4