[buildd-tools-devel] Bug#626361: Bug#626361: Bug#626361: run lintian and piuparts from within the chroot

[Roger Leigh]

On Wed, May 11, 2011 at 12:31:24PM +0200, Reinhard Tartler wrote:
> On Wed, May 11, 2011 at 12:23:43 (CEST), Roger Leigh wrote:
> 
> > On Wed, May 11, 2011 at 11:46:56AM +0200, Reinhard Tartler wrote:
> >> Thanks for implementing the --run-lintian and --run-piuparts hooks in
> >> sbuild. I noticed that both swtiches try to use the system utilities. I
> >> think it would be far more useful if they would install the packages in
> >> the chroot and use them right inside the chroot. Imagine the case that
> >> you have several chroots (oldstable, unstable, testing, lucid, natty,
> >> etc), where using the system lintian from debian/stable might not give
> >> the best results.  In case you used the tool versions from the chroot,
> >> always the matching version of these QA are used and you get better
> >> reports.
> >
> > This shouldn't be a problem--it's just a matter of adding them
> > to the dependency list and running them after the build.
> 
> Well, with this approach, the package wouldn't be built in a "clean"
> chroot any longer but in a chroot with a couple of extra packages. The
> dependency list of lintian and piuparts are both quite large.

We can always just install them on demand, after the build has
completed.  This avoids any issues when them being present during
the build (though the admin would be free to install them manually
so they would be present all the time, if they wished).

> I'm not aware of any packages that expose problems with that, but it
> might be better to have the builds behave the same regardless if
> lintian/piuparts is installed/used or not.

Agreed.

> Thinking a bit more of that, at least for session chroots it might make
> sense to change piuparts to not test in an extra testing-chroot, but
> directly in sbuild's build-chroot. But probably only for session managed
> chroots.

This should also be possible.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20110511/a5da7b8b/attachment.pgp>