[buildd-tools-devel] Bug#626503: dchroot-dsa: Aborts with error parsing dchroot.conf

[Roger Leigh]

Package: dchroot-dsa
Version: 1.4.19-1
Severity: serious
Tags: patch
Justification: Fatal exception

% dchroot-dsa foo
E: basic_string::_S_construct null not valid

% sudo gdb /usr/bin/dchroot-dsa
GNU gdb (GDB) 7.2-debian
Copyright (C) 2010 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>...
Reading symbols from /usr/bin/dchroot-dsa...Reading symbols from /usr/lib/debug/usr/bin/dchroot-dsa...done.
done.
(gdb) catch throw
Catchpoint 1 (throw)
(gdb) run foo
Starting program: /usr/bin/dchroot-dsa foo
[Thread debugging using libthread_db enabled]
Catchpoint 1 (exception thrown), 0x0000003ae48bcf90 in __cxa_throw ()
   from /usr/lib/libstdc++.so.6
(gdb) bt
#0  0x0000003ae48bcf90 in __cxa_throw () from /usr/lib/libstdc++.so.6
#1  0x0000003ae486a8e7 in std::__throw_logic_error(char const*) ()
   from /usr/lib/libstdc++.so.6
#2  0x0000003ae48a7d89 in char* std::basic_string<char, std::char_traits<char>, std::allocator<char> >::_S_construct<char const*>(char const*, char const*, std::allocator<char> const&, std::forward_iterator_tag) ()
   from /usr/lib/libstdc++.so.6
#3  0x0000003ae48a7e63 in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(char const*, std::allocator<char> const&) ()
   from /usr/lib/libstdc++.so.6
#4  0x00000000004246c9 in dchroot_dsa::main::load_config (this=0x7fffdebc6ec0)
    at ../../../../bin/dchroot-dsa/dchroot-dsa-main.cc:64
#5  0x0000000000436ded in schroot::main_base::run_impl (this=0x7fffdebc6ec0)
    at ../../../../bin/schroot/schroot-main-base.cc:244
#6  0x000000000042f917 in schroot_base::main::run (this=0x7fffdebc6ec0, 
    argc=<value optimized out>, argv=0x7fffdebc70e8)
    at ../../../../bin/schroot-base/schroot-base-main.cc:115
#7  0x0000000000424fbe in run<dchroot_dsa::options, dchroot_dsa::main> (
    argc=2, argv=0x7fffdebc70e8)
    at ../../../../bin/schroot-base/schroot-base-run.h:69
#8  main (argc=2, argv=0x7fffdebc70e8)
    at ../../../../bin/dchroot-dsa/dchroot-dsa.cc:44

index c2aa219..86e127d 100644
--- a/bin/dchroot-dsa/dchroot-dsa-main.cc
+++ b/bin/dchroot-dsa/dchroot-dsa-main.cc
@@ -61,7 +61,7 @@ main::load_config ()
       this->config =
        sbuild::chroot_config::ptr(new dchroot_dsa::chroot_config);
       if (this->options->load_chroots == true)
-       this->config->add(DCHROOT_CONF, false);
+       this->config->add("chroot", DCHROOT_CONF);
     }
   else
     {

With the patch:
% dchroot-dsa sid 
E: sid: Chroot not found
(works correctly if sid is valid)

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (550, 'unstable'), (500, 'testing'), (400, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.38-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash