[buildd-tools-devel] Bug#774351: sbuild: patch to fail when hooks fail

Johannes Schauer josch at debian.org
Thu Dec 24 00:08:32 UTC 2015


Control: tag -1 + patch

Hi,

On Fri, 29 May 2015 09:12:39 +0200 Gergely Nagy <algernon at madhouse-project.org> wrote:
> A friend of mine recently ran into this issue too, so I tried to come up with
> a quick & dirty patch to make hooks abort the build if they fail. I haven't
> tested it yet, mind you. In any case, patch is attached. When I hear back
> from either my friend, or from anyone reading this, that the patch works,
> I'll clean it up and resubmit.

unfortunately the hook system was extended quite a bit since you wrote your
patch and it thus doesn't apply at all anymore.

I rewrote the functionality to fit current sbuild master and also added the
additional guard that when there is more than one external command per hook,
that the loop quits at the first failed command.

Thanks anyways for your initial patch!

cheers, josch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Quit-processing-when-external-commands-fail-closes-7.patch
Type: text/x-diff
Size: 6093 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20151224/b4a8917d/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20151224/b4a8917d/attachment.sig>


More information about the Buildd-tools-devel mailing list