[Calendarserver-maintainers] Bug#861764: Bug#861764: closed by Guido Günther <agx at sigxcpu.org> (Re: [Calypso-maint] Bug#861764: calypso: Unicode error)

[Guido Günther]

Hi,
On Sat, Dec 02, 2017 at 02:04:17PM +0100, gregor herrmann wrote:
> Control: unarchive -1
> Control: reopen -1
> 
> > Version: python-vobject/0.9.5-1
> > 
> > On Wed, May 03, 2017 at 09:21:44PM +0200, Guido Günther wrote:
> > > reassign 861764 python-vobject
> > > forcemerge 841247 861764
> > > 
> > > On Wed, May 03, 2017 at 07:34:30PM +0100, Dev PICSL wrote:
> > > [..snip..]
> > > > Traceback (most recent call last):
> > > >   File "/usr/lib/python2.7/dist-packages/calypso/__init__.py", line 418, in
> > > > do_PUT
> > > >     new_item = xmlutils.put(self.path, webdav_request, self._collection,
> > > > context=context)
> > > >   File "/usr/lib/python2.7/dist-packages/calypso/xmlutils.py", line 242, in put
> > > >     return collection.append(name, webdav_request, context=context)
> > > >   File "/usr/lib/python2.7/dist-packages/calypso/webdav.py", line 463, in
> > > > append
> > > >     self.create_file(new_item, context=context)
> > > >   File "/usr/lib/python2.7/dist-packages/calypso/webdav.py", line 389, in
> > > > create_fiel
> > > 
> > > Upstream python-vobject is working on a fix:
> > > 
> > >     https://github.com/eventable/vobject/issues/51
> > > 
> > > I've posted a workaround for calypso recently:
> > > 
> > >     https://keithp.com/pipermail/calypso/2017-April/000345.html
> > > 
> > > which I'll push if upstream doesn't resolve the issue in the near
> > > future.
> > 
> > Fixed in the recent release.
> 
> I'm afraid this bug is not fixed or has reappeared ...
> Yesterday I did some upgrades on a machine running calypso, among
> them
> 
> [UPGRADE] python-vobject:amd64 0.8.1c-4 -> 0.9.5-1
> 
> and the next `calypso --import …' led to
> 
> Failed to import: /tmp/whatever.ics
> Traceback (most recent call last):
>   File "/usr/lib/python2.7/dist-packages/calypso/webdav.py", line 524, in import_file
>     self.import_item(new_item, path)
>   File "/usr/lib/python2.7/dist-packages/calypso/webdav.py", line 501, in import_item
>     self.rewrite_file(new_item, context={})
>   File "/usr/lib/python2.7/dist-packages/calypso/webdav.py", line 419, in rewrite_file
>     context['action'] = u'Modify %s'%item
> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 7: ordinal not in range(128)
> 
> Same with 0.9.3-3; 0.8.1c-4 works.

I won't promise that I have the time and energy to debug this in the
near future but could you please

- attach a a file that triggers the exception
- check current calypso git

     https://github.com/calypso-server/calypso

and see if this look better? I'm running current git without any issues
since quiet some time and tests used to pass as well.

Cheers,
 -- Guido