[debhelper-devel] Bug#814856: debhelper: dh_install -X option is broken

[Niels Thykier]

On Tue, 16 Feb 2016 01:29:09 +0000 James Cowgill
<james410 at cowgill.org.uk> wrote:
> Source: debhelper
> Version: 9.20160115
> Severity: important
> X-Debbugs-CC: Dmitry Shachnev <mitya57 at gmail.com>
> Control: affects -1 src:codelite
> 
> Hi,
> 
> It seems the -X option of dh_install is either broken or its
> behaviour has changed recently. With newer versions of debhelper
> codelite fails to build with this error:
> 
> >    debian/rules override_dh_install
> > make[1]: Entering directory '/«BUILDDIR»/codelite-9.1+dfsg'
> > dh_install  -Xcodelite-lldb -XLLDBDebugger.so
> > dh_install: codelite-plugins missing files: usr/bin/codelite-lldb
> > dh_install: codelite-plugins missing files: usr/lib/codelite/LLDBDebugger.so
> > dh_install: missing files, aborting
> > debian/rules:40: recipe for target 'override_dh_install' failed
> > make[1]: *** [override_dh_install] Error 2
> 
> Bisected to this commit:
> 8a9b2f22871f1cd612f4a5660a943dd2ca5d4f24 is the first bad commit
> commit 8a9b2f22871f1cd612f4a5660a943dd2ca5d4f24
> Author: Dmitry Shachnev <mitya57 at gmail.com>
> Date:   Tue Jan 5 16:57:16 2016 +0300
> 
>     dh_install: Fail late when there were non-existing files
>     
>     Print warnings for each glob that did not match anything, and fail
>     after processing all packages if there were any missing files.
>     
>     Closes: #488346
>     
>     Signed-off-by: Niels Thykier <niels at thykier.net>
> 
> Unless I've misread the documentation, it seems that what I'm doing
> should work here.
> 
> Thanks,
> James
Hi James,

Sorry for the late reply to this bug.

Could you please test if this is still a problem in debhelper 10.8?  I
recently rewrote most of the relevant parts of dh_install, so Dmitry's
patch is no longer applicable.  At the same time, the current code looks
like it should handle this case as you expect (i.e. expand glob; assert
something matches and then filter out excluded paths)

Thanks,
~Niels