[debhelper-devel] Bug#814856: debhelper: dh_install -X option is broken

[James Cowgill]

Hi,

On 19/09/17 10:24, Niels Thykier wrote:
> On Tue, 16 Feb 2016 01:29:09 +0000 James Cowgill
> <james410 at cowgill.org.uk> wrote:
>> Source: debhelper
>> Version: 9.20160115
>> Severity: important
>> X-Debbugs-CC: Dmitry Shachnev <mitya57 at gmail.com>
>> Control: affects -1 src:codelite
>>
>> Hi,
>>
>> It seems the -X option of dh_install is either broken or its
>> behaviour has changed recently. With newer versions of debhelper
>> codelite fails to build with this error:
>>
>>>    debian/rules override_dh_install
>>> make[1]: Entering directory '/«BUILDDIR»/codelite-9.1+dfsg'
>>> dh_install  -Xcodelite-lldb -XLLDBDebugger.so
>>> dh_install: codelite-plugins missing files: usr/bin/codelite-lldb
>>> dh_install: codelite-plugins missing files: usr/lib/codelite/LLDBDebugger.so
[...]

> Sorry for the late reply to this bug.
> 
> Could you please test if this is still a problem in debhelper 10.8?  I
> recently rewrote most of the relevant parts of dh_install, so Dmitry's
> patch is no longer applicable.  At the same time, the current code looks
> like it should handle this case as you expect (i.e. expand glob; assert
> something matches and then filter out excluded paths)

I think it's still broken. This is with debhelper 10.8:
>    debian/rules override_dh_install
> make[1]: Entering directory '/<<BUILDDIR>>/codelite-10.0+dfsg'
> dh_install  -Xcodelite-lldb -XLLDBDebugger.so
> dh_install: Cannot find (any matches for) "usr/bin/codelite-lldb" (tried in ., debian/tmp)
> 
> dh_install: codelite-plugins missing files: usr/bin/codelite-lldb
> dh_install: Cannot find (any matches for) "usr/lib/codelite/LLDBDebugger.so" (tried in ., debian/tmp)
> 
> dh_install: codelite-plugins missing files: usr/lib/codelite/LLDBDebugger.so
> dh_install: missing files, aborting
> debian/rules:40: recipe for target 'override_dh_install' failed

However, looking at this bug again, I might have misunderstood the -X
option here. As you said, at the moment it will filter out excluded
files after checking that the glob matches something. I think I was
trying to exclude entire globs from being considered (ignoring missing
files in a specific case) as opposed to excluding files which would have
otherwise been installed.

With that, I think you can close the bug. After originally filing this
bug, I changed the codelite packaging to something which worked properly
and I'm fine with keeping that.

Thanks,
James

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/debhelper-devel/attachments/20170919/980be340/attachment-0001.sig>