[Debian-eeepc-devel] patch for GSM toggle

[Santi Béjar]

Let me just comment about the patch style. You can ignore me as I'm
not the maintainer.

2009/7/10 Thiemo Nagel <thiemo.nagel at ph.tum.de>:
> diff --git a/debian/eeepc-acpi-scripts.default
> b/debian/eeepc-acpi-scripts.default
> index 8fe4a7c..55e7c79 100644
> --- a/debian/eeepc-acpi-scripts.default
> +++ b/debian/eeepc-acpi-scripts.default
> @@ -1,5 +1,5 @@
>  # by default OSD output of function keys is disabled because it's too slow
> -# set to yes if you want fancy osd overlayS
> +# set to yes if you want fancy osd overlays

This does not belong to this patch.

[...]

> diff --git a/etc/acpi/actions/wireless.sh b/etc/acpi/actions/wireless.sh
> index 617826a..02e8d09 100755
> --- a/etc/acpi/actions/wireless.sh
> +++ b/etc/acpi/actions/wireless.sh
> @@ -1,6 +1,11 @@
>  #!/bin/sh
>
> -. /usr/share/eeepc-acpi-scripts/functions.sh
> +# do nothing if package is removed
> +PKG=eeepc-acpi-scripts
> +FUNC_LIB=/usr/share/$PKG/functions.sh
> +[ -e $FUNC_LIB ] || exit 0
> +
> +. $FUNC_LIB

Although I agree with this hunk it is for another patch.

>
>  detect_rfkill eeepc-wlan
>  wlan_control="$RFKILL"
> @@ -45,7 +50,7 @@ case "$cmd" in
>        fi
>        ;;
>     *)
> -       echo "Usage: $0 [on|off]"
> +       echo "Usage: $0 [on|off|detect]"

again.

If the patch does just one thing it is easier to revert without
reverting the extra hunks.

Also you could provide a patch for debian/changelog to update it.

You could also provide a commit message (similar to the above comment)
and use "git format-patch", so the maintainer can apply it with "git
am".

Again, these are suggestions to make the maintainer/reviewer life
easier, but as I'm not the maintainer you can easily ignore them. And
the maintainer could just tell me to shut up :-)

HTH,
Santi