[Debian-hebrew-package] Bug#751503: fribidi: Parameter declarations of function fribidi_get_bidi_type differ in signedness

[أحمد المحمودي]

On Fri, Aug 15, 2014 at 11:57:34PM +0100, Michael Tautschnig wrote:
> Looking into this indeed two different definitions of FRIBIDI_UNICHAR_LOCAL are
> being picked up.
> 
> In lib/.libs/fribidi-bidi-types.o, FRIBIDI_UNICHAR_LOCAL expands to wchar_t
> (from line 95), whereas in bin/fribidi-bidi-types.o, FRIBIDI_UNICHAR_LOCAL
> expands to fribidi_uint32 (from line 97).
> 
> This difference is caused by SIZEOF_WCHAR_T being undefined (!) in
> bin/fribidi-bidi-types.o. This, again, is the result of bin/fribidi-bidi-types.c
> not actually including config.h, whereas lib/fribidi-bidi-types.c would include
> lib/common.h, when eventually does include config.h.
> 
> It seems the problem would best be fixed by uniformly having
> 
> #if HAVE_CONFIG_H+0
> # include <config.h>
> #endif
> 
> as first preprocessor directive in every .c file (this is taken from common.h).
---end quoted text---

  Well, seems to me that this might rather be a problem with the 
  upstream build scripts.

  I think that the object files in bin/ should actually be linked against the 
  built libfribidi.so instead of being linked against the object files 
  in lib/

  What do you think ?

-- 
 ‎أحمد المحمودي (Ahmed El-Mahmoudy)
  Digital design engineer
 GPG KeyID: 0xEDDDA1B7
 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8  B176 BC19 6A94 EDDD A1B7
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/debian-hebrew-package/attachments/20150115/87aaad89/attachment.sig>