[Debian-hebrew-package] Bug#751503: fribidi: Parameter declarations of function fribidi_get_bidi_type differ in signedness

Michael Tautschnig mt at debian.org
Fri Jan 16 20:28:54 UTC 2015


On Thu, Jan 15, 2015 at 21:16:49 +0200, أحمد المحمودي wrote:
> On Fri, Aug 15, 2014 at 11:57:34PM +0100, Michael Tautschnig wrote:
> > Looking into this indeed two different definitions of FRIBIDI_UNICHAR_LOCAL are
> > being picked up.
> > 
> > In lib/.libs/fribidi-bidi-types.o, FRIBIDI_UNICHAR_LOCAL expands to wchar_t
> > (from line 95), whereas in bin/fribidi-bidi-types.o, FRIBIDI_UNICHAR_LOCAL
> > expands to fribidi_uint32 (from line 97).
> > 
> > This difference is caused by SIZEOF_WCHAR_T being undefined (!) in
> > bin/fribidi-bidi-types.o. This, again, is the result of bin/fribidi-bidi-types.c
> > not actually including config.h, whereas lib/fribidi-bidi-types.c would include
> > lib/common.h, when eventually does include config.h.
> > 
> > It seems the problem would best be fixed by uniformly having
> > 
> > #if HAVE_CONFIG_H+0
> > # include <config.h>
> > #endif
> > 
> > as first preprocessor directive in every .c file (this is taken from common.h).
> ---end quoted text---
>   Well, seems to me that this might rather be a problem with the 
>   upstream build scripts.
>   I think that the object files in bin/ should actually be linked against the 
>   built libfribidi.so instead of being linked against the object files 
>   in lib/
>   What do you think ?

I'm not really sure this is an appropriate solution - unless the files in lib/
are not used at all? If, however, they are used, then linking differently will
not solve the problem that the object files themselves are built with
inconsistent information.

So my opinion is:

- If the files in lib/ aren't used, then linking against libfribidi.so is good,
  but then there's the question of what lib/ is good for at all?
- If, on the other hand, those files are used, then all of them should have
  SIZEOF_WCHAR_T defined (possibly by including config.h).


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 859 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-hebrew-package/attachments/20150116/94b7cdfe/attachment.sig>

More information about the Debian-hebrew-package mailing list