[Debian-olpc-devel] RFP: python-xklavier -- Python bindings for libxklavier

[Luke Faraone]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 04/16/2010 11:51 AM, Jonas Smedegaard wrote:
> You should probably include python-autotools.mk (not autotools.mk). As
> is declaring DEB_PYTHON_SYSTEM has no affect, and quite likely the
> binary package do not follow Python Policy properly.

Done. This is not included in the version of CDBS in Lucid, so we'll
have to backport it if we want to ship this for PPA users :(


> xklavier/Makefile.in needs to have ./ prepended in line 25 of
> debian/copyright (so that it works with "find -path").  Or more
> elegantly it can simply be removed, as "Makefile.in" covers all files by
> that name recursively (which conversely means you should be cautious to
> not accidentally covver too many files - prepend ./ if in uncertain).

Corrected. In this case, all "Makefile.in"s are under that license, afaict.

> Also, I recommend to make use of CDBS build-dependency auto-resolving:
> 
>  1. copy debian/control to debian/control.in
>  2. edit debian/control.in to build-depend on @cdbs@ (not cdbs)
>  3. Auto-resolve:
>     DEB_MAINTAINER_MODE=1 fakeroot debian/rules clean
>  4. Check resulting debian/control, remove excess explicit    
> build-dependencies (e.g. debhelper), and repeat step 3.

Done, and committed.

> I also recommend to enable copyright-check to track new or changed
> licensing or copyrights:
> 
>  1. include CDBS rule utils.mk
>  2. touch debian/copyright_hints
>  3. Generate and preserve new hints:
>     DEB_MAINTAINER_MODE=1 debian/rules pre-build
>     mv debian/copyright_newhints debian/copyright_hints
>  4. check that all files, copyrights and licenses in hints file match
>     those manually declared in copyright file (you may want to order the
>     contents of the copyright file similar to the hints file to ease    
> future updates with simple diff).

Done. It noted some things which I missed, but also a bunch of things
with no copyright which should have been covered by the implicit "*" in
the first copyright declaration.


Anything else that needs fixing?


- -- 
Luke Faraone
http://luke.faraone.cc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkvIlJoACgkQtrC51grHAgbXMgCgpLC1kioiIefEAkC8OqtMZh1Y
WagAn1Qk3Cv0jMKV6c4OXbfab1velfYo
=GjXR
-----END PGP SIGNATURE-----