[Debian-olpc-devel] sugar-terminal-activity troubles

[Luke Faraone]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/01/2010 12:44 PM, Jonas Smedegaard wrote:
> On Thu, Jul 01, 2010 at 12:04:53PM -0400, Luke Faraone wrote:
>> However, when I attempt to build the package, it builds as
>> debian-native, despite having used[1] pristine-tar on git-import-orig
>> and in debian/gbp.conf.
>>
>> Is there something I'm not doing correctly?
> 
> Git repository looks odd - no tags.  Did you perhaps forget to do a "git
> push --tags"?

Yeah, I did. And I subsequently removed the original repository, so I
retagged manually. I think I did it properly.

> An unlrelated bug I discovered is that you build-depend on the virtual
> package python-sugar-toolkit which works for pbuilder but not buildd -
> and more importantly is a Debian Policy violation: You need to instead
> build-depend on a real package (and optionally add a fallback on the
> virtual package, which is recommended as it will ease backporting):
> 
> Build-Depends: [...], python-sugar-toolkit-0.88 | python-sugar-toolkit

Yes. I solved this by adding "DEB_SUGAR_BRANCHES"[1] to debian/rules. I
read /usr/share/cdbs/1/class/python-sugar.mk, which said:
> # Space-delimited list of supported branches, lowest listed first
> # (comment out if all current branches are supported)
> # NB! This variable must be declared *above* inclusion of this snippet
> #DEB_SUGAR_BRANCHES = 0.84 0.86

Since it said "comment out if all current branches are supported", I
didn't include it. Should I file a bug saying something similar to "If
DEB_SUGAR_BRANCHES is not defined, assume all branches"?


[1]:
http://git.debian.org/?p=collab-maint/sugar-terminal-activity.git;a=commitdiff;h=3da8526f9d51004985f5468975e2f8f9972f901f

- -- 
Luke Faraone
http://luke.faraone.cc/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkwsyTIACgkQtrC51grHAgacuQCcD4zf6tY6tcU+Hp1Ez9aRvutg
jVkAnjc743qhRp71/SZ9Vvu8Vp6Z/MhM
=BGi3
-----END PGP SIGNATURE-----