[Debian-olpc-devel] Review of sugar-etoys-activity

[Luke Faraone]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Review based off commit ce98376.

I did make some changes, so you'll need to pull in my commits before you
get working on this to avoid a merge conflict.

As before, run "debuild clean" before committing your changes if you've
built the package. I ran the rule and it removed a number of files in
debian/. (git commit 900dbaf)

What follows are a list of items I found but did not correct. Please do
so and commit each fix you implement separately.

 * sugar-etoys-activity_115.orig.tar.gz.cdbs-config_list:
   - Why is this file here? Please remove it.
 * debian/watch:
   - You can remove the comment "# REPLACE WITH THE PROPER USCAN-ized
URL TO UPSTREAM".

 * debian/changelog:
   - Remove "  * Switch to dpkg-source 3.0 (quilt) format", usually you
don't mention packaging changes that take place before an upload.

 * debian/rules:
   - On the wikipage, you declare "all", but have not made the
respective changes to the rules file to reflect that.¹

 * debian/control.in:
   - description lines should be wrapped at 72 characters.

 * debian/copyright:
   - Your name is mis-formatted in the Copyright field.
   - I don't see any claim by Red Hat of copyright on setup.py, you can
probably omit it.

¹: See
http://lists.alioth.debian.org/pipermail/debian-olpc-devel/2010-July/002600.html
and related
http://lists.alioth.debian.org/pipermail/debian-olpc-devel/2010-July/002603.html
for information on how to do so.

- -- 
Luke Faraone
http://luke.faraone.cc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkxF2tkACgkQtrC51grHAgYinwCgqgOfuw1kJ/Ui4g4xk+vei6c6
3rAAn0/S/8NmkQ/wsPDqXZS0vlcKUUle
=tdP1
-----END PGP SIGNATURE-----