[Debian-olpc-devel] Review of sugar-etoys-activity
luke at faraone.cc
Wed Jul 21 16:01:35 UTC 2010
-----BEGIN PGP SIGNED MESSAGE-----
On 07/21/2010 05:25 AM, Ankur Khurana wrote:
> thanks for your review . I went through all the changes you mentioned
> here.Well i did tested the packages on Debian , but i made a mistake of
> not editing them in Ubuntu and committing my change .I sincerely
> apologize for that mistake on my part.I would like you to review etoys
> again and as i have made changes as suggested by you and see what needs
> to worked on it right now.
Review based off commit 8516ff4.
On 07/20/2010 01:20 PM, Luke Faraone wrote:
> * debian/copyright:
> - Your name is mis-formatted in the Copyright field.
> - I don't see any claim by Red Hat of copyright on setup.py, you can
> probably omit it.
- This file is present in the upstream tarball, but not in your
repository. Why was it removed in commit 1601547? Please re-add it.
- From looking at the omitted COPYING file, the code is not GPL-2+
nor is it © OLPC. Please inspect COPYING and update the file
accordingly. I think the appropriate tag is "other-X11", and you'll want
to quote the license verbatim below the tag.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
-----END PGP SIGNATURE-----
More information about the Debian-olpc-devel