[Debian-olpc-devel] Review of sugar-etoys-activity
luke at faraone.cc
Sat Jul 24 16:24:09 UTC 2010
-----BEGIN PGP SIGNED MESSAGE-----
On 07/21/2010 12:01 PM, Luke Faraone wrote:
> * COPYING:
> - This file is present in the upstream tarball, but not in your
> repository. Why was it removed in commit 1601547? Please re-add it.
> * debian/copyright:
> - From looking at the omitted COPYING file, the code is not GPL-2+
> nor is it © OLPC. Please inspect COPYING and update the file
> accordingly. I think the appropriate tag is "other-X11", and you'll want
> to quote the license verbatim below the tag.
Review based on git commit 654a819.
- Line 36: Put a space between ":" and "©"
- Lines 38-54: Indent the license text by one space, as done with
the GPL above
- Lines 44, 46: Put a "." in addition to the single-space indent to
signify a blank line, again as done with the GPL above.
- Line 29: Delete this empty line.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
-----END PGP SIGNATURE-----
More information about the Debian-olpc-devel