[Debian-olpc-devel] Package Review Request : sugar-moon-activity

[Luke Faraone]

On 10/13/2010 03:35 PM, Ishan Bansal wrote:
> As mentioned in your mail i have made the desired changes in the Moon
> activity package.

See below for my comments.

On 10/09/2010 11:28 AM, Luke Faraone wrote:
| that the copyright for the overall package was listed as "One Laptop
| Per Child", and that Gary was listed as the author only of moon.py.
|
| I didn't see anything that indicated the package was at all written by
| OLPC employees, so I'm confused as to the source of the message.
| Please clarify the rationale, including where the information was
| taken from, or remove the notice.

Nothing in your changes corrected this. The issue was not the
capitalization of OLPC, but that the upstream project does *not* seem to
incorporate any code written by OLPC employees. If I'm correct, OLPC
should not be listed as the copyright holder.

| license header to point to /usr/share/common-licenses/GPL-2,

The path is still listed as "/usr/share/common-licenses/GPL".

Also, there is a typo in the description, "low-resource" is misspelled.

Other than that, you're good.

-- 
╒═════════════════════════════════════════════════════════════════╕
│Luke Faraone                          ╭Debian / Ubuntu Developer╮│
│http://luke.faraone.cc                ╰Sugar Labs, Systems Admin╯│
│PGP: 5189 2A7D 16D0 49BB 046B  DC77 9732 5DD8 F9FD D506          │
╘═════════════════════════════════════════════════════════════════╛

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/debian-olpc-devel/attachments/20101014/b2e9a309/attachment.pgp>