[debpool] some patches for your review

[Andres Mejia]

Hello Alexei,

Thanks for your patches. I've tested them and applied them to my
branch. There was one minor change I did. The message that appears
when a package is uploaded for an unconfigured architecture, I changed
the message to say this, "The archive isn't configured for '$chg_arch'
type packages.". The message then would make more sense when packages
for other kernels besides linux are uploaded.

On Jan 15, 2008 9:15 PM, Alexei Chetroi
<alexei.chetroi at lexa.uniflux-line.net> wrote:
>  Hi Andres,
>
>  I have a few patches and ideas for your version of debpool.
>
> 1st patch moves config parsing from bin/debpool to
> share/DebPool/Config.pm IMHO it keeps debpool more readable and
> maintainable.
>
> 2nd patch adressess this problem: if you will try to install a package
> in a distribution which has not been configured, debpool will:
> a) install that package
> b) package audit will delete that package
> c) Install_List will complain that it cannot install Source/Packages
> files.
> Here are messages from the log:
> 2008-01-14 22:05:37 [GENERAL/INFO] Processing changefile 'debpool_0.2.3_i386.changes'
> 2008-01-14 22:05:37 [INSTALL/INFO] Installed debpool (0.2.3) to distribution(s): experimental
> 2008-01-14 22:05:37 [AUDIT/DEBUG] Unlinked obsolete pool file '/home/lex/dp/debian/pool/main/d/debpool/debpool_0.2.3_all.deb'
> ...
> 2008-01-14 22:05:37 [GENERAL/ERROR] Couldn't install distribution files for experimental/main/source: Couldn't install distribution file '/tmp/tEmY7IEgGG' to '/home/lex/dp/debian/dists/experimental/main/source/Sources': No such file or directory
>
> My guess is that original author intended to write something like 2nd patch.
>
>
> And the 3rd patch addresses a really small problem. I'd say it is not a
> problem really, just a little protection from the fools :) I've tried to
> upload a package for an unconfigured architecture. Debpool reported
> successful package installation, but indeed package was just dropped. So I've
> added this check to reject an upload, if it contains an unconfigured
> arch.
>
>
>  Any feedback will be greatly apreciated.
>
>  Kind regards.
>
> --
> Alexei Chetroi
>
> Smile... Tomorrow will be worse. (c) Murphy's Law
>



-- 
Regards,
Andres Mejia