[debpool] Fwd: some patches for your review

[Andres Mejia]

Here are some patches I was sent by Alexei for my version of debpool.
I haven't had the chance to test them yet, but I thought I would post
them to the list in case others would like to review them as well.


---------- Forwarded message ----------
From: Alexei Chetroi <alexei.chetroi at lexa.uniflux-line.net>
Date: Jan 15, 2008 9:15 PM
Subject: some patches for your review
To: Andres Mejia <mcitadel at gmail.com>


 Hi Andres,

 I have a few patches and ideas for your version of debpool.

1st patch moves config parsing from bin/debpool to
share/DebPool/Config.pm IMHO it keeps debpool more readable and
maintainable.

2nd patch adressess this problem: if you will try to install a package
in a distribution which has not been configured, debpool will:
a) install that package
b) package audit will delete that package
c) Install_List will complain that it cannot install Source/Packages
files.
Here are messages from the log:
2008-01-14 22:05:37 [GENERAL/INFO] Processing changefile
'debpool_0.2.3_i386.changes'
2008-01-14 22:05:37 [INSTALL/INFO] Installed debpool (0.2.3) to
distribution(s): experimental
2008-01-14 22:05:37 [AUDIT/DEBUG] Unlinked obsolete pool file
'/home/lex/dp/debian/pool/main/d/debpool/debpool_0.2.3_all.deb'
...
2008-01-14 22:05:37 [GENERAL/ERROR] Couldn't install distribution
files for experimental/main/source: Couldn't install distribution file
'/tmp/tEmY7IEgGG' to
'/home/lex/dp/debian/dists/experimental/main/source/Sources': No such
file or directory

My guess is that original author intended to write something like 2nd patch.


And the 3rd patch addresses a really small problem. I'd say it is not a
problem really, just a little protection from the fools :) I've tried to
upload a package for an unconfigured architecture. Debpool reported
successful package installation, but indeed package was just dropped. So I've
added this check to reject an upload, if it contains an unconfigured
arch.


 Any feedback will be greatly apreciated.

 Kind regards.

--
Alexei Chetroi

Smile... Tomorrow will be worse. (c) Murphy's Law



-- 
Regards,
Andres Mejia
-------------- next part --------------
A non-text attachment was scrubbed...
Name: load_config_from_module.diff
Type: text/x-diff
Size: 2587 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/debpool-devel/attachments/20080115/0e34419b/attachment.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: check_if_dist_is_configured.diff
Type: text/x-diff
Size: 924 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/debpool-devel/attachments/20080115/0e34419b/attachment-0001.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: check_uploaded_arch.diff
Type: text/x-diff
Size: 1035 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/debpool-devel/attachments/20080115/0e34419b/attachment-0002.diff