[debpool] style changes to code, build system

Andres Mejia mcitadel at gmail.com
Mon Jun 2 18:23:09 UTC 2008


On Sunday 01 June 2008 9:32:26 am Hilko Bengen wrote:
> I have fixed a number of Perl::Critic's most "serious" warnings and
> changed the build/install system in order to make use of Perl's own
> tools. Moreover, I have converted the debpool.1 manpage to POD and
> attached it to the debpool program itself.
>
> Comments?

I've looked at the patches and indeed, it does seem to be just general code 
cleanup and a new build system. I don't have a problem if you uploaded this.

Just a few things, can you change the AUTHOR in the Makefile.PL to "DebPool 
Developers <debpool-devel at lists.alioth.debian.org>"? Also, you have the 
VERSION set as 0.4 instead of 0.3.2 as in the changelog.

Can you push your changes to the repository? I wouldn't mind if you merged and 
pushed directly to the "master" branch. There's been so many changes done 
that I don't think we'll be starting over from 0.2.3 anyway.

-- 
Regards,
Andres
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://lists.alioth.debian.org/pipermail/debpool-devel/attachments/20080602/5535bfad/attachment.pgp 


More information about the Debpool-devel mailing list